Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.2.7, 4.3.4
Affects Version/s: 4.2.7, 4.3.4
Component/s: Files API
Labels:

Affected Branches:
MOODLE_402_STABLE, MOODLE_403_STABLE
Fixed Branches:
MOODLE_402_STABLE, MOODLE_403_STABLE
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull 4.3 Branch:
~~MDL-81306~~-403
Pull 4.3 Diff URL:
https://github.com/andrewnicols/moodle/compare/1c530d86d1...MDL-81306-403?w=1
Pull Main Branch:
~~MDL-81306~~-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/c895def59b...MDL-81306-main?w=1
Testing Instructions:

Hide

Review documentation change
Unit tests (CI)

Show
Review documentation change Unit tests (CI)

THis doc introduced in 80648 literally cannot be supported, by design. It must be reverted.

The per-request directory is deleted during the shutdown of the thread, and it cannot be certain that the header has been sent before this time, or that the server will have processed the file before it is removed.

Discovered while testing

MDL-81269 Database activity with file - no export with X-Sendfile/make_request_directory

Open

is a regression caused by

MDL-80648 $CFG->xsendfilealiases in config-dist.php is missing localrequestdir

Closed

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Daniel Ziegenberg

Integrator:: Shamim Rezaie

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, Daniel Ziegenberg, Sara Arjona (@sarjona), Shamim Rezaie

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 20/Mar/24 10:57 PM

Updated:: 12/Apr/24 8:23 PM

Resolved:: 12/Apr/24 8:23 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 25m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify