Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81203

Increase ROUGH_NUMBER_OF_STRINGS to next thoushand (33K)

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.5
    • 4.4
    • Administration
    • MOODLE_404_STABLE
    • MOODLE_405_STABLE
    • Hide
      1. Install a main site from scratch.
      2. In the database, ensure that the "tool_customlang" table is empty (delete all the records if not).
      3. As admin, go to /admin/tool/customlang/index.php
      4. In the menu, choose "English (en)"
      5. Click on the "Open language pack for editing" button.
      6. Verify that a progress bar appears and, slowly, it shows the progress.
      7. Verify that, at the end, the bar ends with "Language pack loaded
        100%" texts.
      8. Verify that, at the end, the bad doesn't make any strange thing, like getting the "green" bar progressing too much or becoming bigger.
      9. Click "Back" in the browser.
      10. Click on the "Open language pack for editing" button again.
      11. Verify that, this time, it loads really faster and the bar behaves ok (as described in the fisrt load performed few steps above).
      12. Go to the database and check how many records the "tool_customlang" table has. With SQL, you can do (you may need to change or remove the "mdl_" prefix):

        SELECT COUNT(*) FROM mdl_tool_customlang

      13. Verify that the number is 32210 or higher.
      Show
      Install a main site from scratch. In the database, ensure that the "tool_customlang" table is empty (delete all the records if not). As admin, go to /admin/tool/customlang/index.php In the menu, choose "English (en)" Click on the "Open language pack for editing" button. Verify that a progress bar appears and, slowly, it shows the progress. Verify that, at the end, the bar ends with "Language pack loaded 100%" texts. Verify that, at the end, the bad doesn't make any strange thing, like getting the "green" bar progressing too much or becoming bigger. Click "Back" in the browser. Click on the "Open language pack for editing" button again. Verify that, this time, it loads really faster and the bar behaves ok (as described in the fisrt load performed few steps above). Go to the database and check how many records the "tool_customlang" table has. With SQL, you can do (you may need to change or remove the "mdl_" prefix): SELECT COUNT(*) FROM mdl_tool_customlang Verify that the number is 32210 or higher.

      Whenever the ROUGH_NUMBER_OF_STRINGS falls under the number of strings really existing in a lang pack, the progress bar when loading the lang for customisation does "fun" things.

      This was detected @ MDL-70014, because the constant was really outdated there.

      Recently, we have surpassed the current (32K) mark in the English pack, and it's time to bump to the next thousand (33K).

      Here it's the list of checks, for the records:

      • Oct 2023 (Moodle 4.1): 30996 (no changes).
      • Sep 2023 (Moodle 4.3): 32036 (no changes).
      • Mar 2024 (Moodle 4.4): 32210 (raise, this issue)

        1. (1) 11 Passed -- (Main)MDL-81203.png
          41 kB
          Kim Jared Lucas
        2. (1) 13 Passed -- (Main)MDL-81203.png
          18 kB
          Kim Jared Lucas
        3. (1) 6 Passed -- (Main)MDL-81203.png
          43 kB
          Kim Jared Lucas
        4. (1) 7 Passed -- (Main)MDL-81203.png
          54 kB
          Kim Jared Lucas
        5. (1) 8 Passed -- (Main)MDL-81203.png
          47 kB
          Kim Jared Lucas

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Paul Holden Paul Holden
            Ilya Tregubov Ilya Tregubov
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 47 minutes
                47m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.