Loading...

XML

Word

Printable

Type: Task
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.4
Component/s: Enrolments
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/paulholden/moodle
Pull Main Branch:
~~MDL-81185~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-81185
Testing Instructions:
Hide

Execute the following:

$ git grep -B1 -A2 get_welcome_email_contact

Confirm the only matches are the original method (which emits final deprecation notice) and upgrade notes regarding removal
Show
Execute the following: $ git grep -B1 -A2 get_welcome_email_contact Confirm the only matches are the original method (which emits final deprecation notice) and upgrade notes regarding removal
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-81185~~ using repository: https://github.com/paulholden/moodle

main [branch: MDL-81185 | CI Job]

Error: The ~~MDL-81185~~ branch at https://github.com/paulholden/moodle is very old (>60 days ago). Please rebase against current main.

Should these errors be fixed?

Built on: Tue Mar 4 06:07:29 UTC 2025
Show
Fails against automated checks. Checked MDL-81185 using repository: https://github.com/paulholden/moodle main [branch: MDL-81185 | CI Job ] Error: The MDL-81185 branch at https://github.com/paulholden/moodle is very old (>60 days ago). Please rebase against current main. Should these errors be fixed? Built on: Tue Mar 4 06:07:29 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-81185~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18017/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61554/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61555/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61556/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61557/ App tests (stable app version) --> unrelated app failures

Built on: Wed Jan 22 06:15:15 AM UTC 2025
Show
Launching automatic jobs for branch MDL-81185 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18017/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61554/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61555/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61556/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61557/ App tests (stable app version) --> unrelated app failures Built on: Wed Jan 22 06:15:15 AM UTC 2025

This method will be deprecated in ~~MDL-4188~~.

This issue is to finally remove this legacy method()

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-81185_test.png
12/Mar/25 3:55 PM
114 kB
Sara Arjona (@sarjona)

has to be done after

MDL-4188 Send course welcome message for manual and self enrolments

Closed

Assignee:: Paul Holden

Reporter:: Huong Nguyen

Peer reviewer:: Andrew Lyons

Integrator:: Sara Arjona (@sarjona)

Tester:: Sara Arjona (@sarjona)

Participants:: Andrew Lyons, CiBoT, Huong Nguyen, Paul Holden, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 11/Mar/24 11:04 AM

Updated:: 11/Apr/25 6:01 PM

Resolved:: 14/Mar/25 11:32 PM

Estimated:

Not Specified

Remaining:

Logged:

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify