Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81163

The <mod>_is_branded callback should use component_callback()

XMLWordPrintable

    • MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • MDL-81163-main
    • Hide
      1. Login as admin.
      2. Create a course.
      3. Enable edit mode.
      4. Click the "Add an activity or resource".
      5. Check the H5P activity is displayed using their logo with their original colour.
      6. Check the rest of the activities (but BigBlueButton, in case it's enabled), are using the specific colour for their purpose.
      Show
      Login as admin. Create a course. Enable edit mode. Click the "Add an activity or resource". Check the H5P activity is displayed using their logo with their original colour. Check the rest of the activities (but BigBlueButton, in case it's enabled), are using the specific colour for their purpose.
    • 1
    • HQ 2024 Sprint I1.2 Moppies

      In MDL-78284, a new callback <modname>_is_branded was added, to let modules override it when their loge must be displayed as it is (so without applying any filter to colour based on their main purpose).

      It was called using:

      $isbrandedfunction = $mod->name.'_is_branded';
      		 
      $isbranded = function_exists($isbrandedfunction) ? $isbrandedfunction() : false;

      but we should use instead of:

      $isbranded = component_callback($mod->name, 'is_branded');

       

      Thanks dobedobedoh for raising this! <3

        1. (1) 6 Passed -- (Main)MDL-81163.png
          (1) 6 Passed -- (Main)MDL-81163.png
          115 kB

            sarjona Sara Arjona (@sarjona)
            sarjona Sara Arjona (@sarjona)
            Carlos Escobedo Carlos Escobedo
            Paul Holden Paul Holden
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 3 minutes
                1h 3m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.