-
Bug
-
Resolution: Fixed
-
Major
-
4.1.10, 4.2.2, 4.3, 4.4
-
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE
-
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
-
MDL-81060-401-fix -
MDL-81060-403-fix -
MDL-81060-main-fix -
1. Testing SCORM
- Login as admin
- Set Private files space (userquota) to 0 MB on the site administrator.
- Create a course with the Maximum upload size is 500 KB
- Assign user as a teacher role to the Course
- Logout
- Login as the teacher
- Add SCORM package activity
- Specify the name with "SCORM Test"
- Download the SCORM sample file mdl81060_scorm_sample.zip
- In the Package file, upload the SCORM sample file
- Click the Save and Display button
- VERIFY the SCORM created successfully without any errors
- VERIFY the SCORM can be previewed.
2. Testing Private Files
- Please follow the MDL-74641 testing instructions
- Note: Ignore the expected error message at step 12. What we instead expect to see is an error saying the zip file contents cannot be read.
- Verify the testing is passed without any errors.
1. Testing SCORM Login as admin Set Private files space (userquota) to 0 MB on the site administrator. Create a course with the Maximum upload size is 500 KB Assign user as a teacher role to the Course Logout Login as the teacher Add SCORM package activity Specify the name with "SCORM Test" Download the SCORM sample file mdl81060_scorm_sample.zip In the Package file, upload the SCORM sample file Click the Save and Display button VERIFY the SCORM created successfully without any errors VERIFY the SCORM can be previewed. 2. Testing Private Files Please follow the MDL-74641 testing instructions Note: Ignore the expected error message at step 12. What we instead expect to see is an error saying the zip file contents cannot be read. Verify the testing is passed without any errors.
-
6
-
Team Hedgehog 2024 Sprint 1.2, Team Hedgehog 2024 Sprint 1.3, Team Hedgehog 2024 Sprint 1.4
Plugins such as mod_scorm use zips, which are unzipped and stored in the mdl_files when saved.
Since MDL-74641, there is a check added here that the unzipped file size does not exceed the "Private files space" config:
Two issues with this:
- This is confusing for end users, since mod_scorm doesn't touch the private files area, but this setting "Private files space" affects it. I believe this should be at a minimum renamed to "unzip file area quota"
- It checks the existing usage of files in the users private file area, regardless if the file being unzipped is in the private file area (in scorm, they are not)
A better solution would be being able to define max file sizes per-area (so for example, scorm could be 200mb but private files could be 1mb, etc...), and then check the respective area for existing usage.
