Loading...

XML

Word

Printable

Type: Task
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.4, 5.0
Component/s: Authentication
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_404_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Main Branch:
~~MDL-80995~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-80995
Testing Instructions:
Hide

Execute the following:

$ git grep -A1 -B2 "setup_factor("

Confirm the only matches are the original methods (which emit final deprecation notice) and upgrade notes regarding removal
Show
Execute the following: $ git grep -A1 -B2 "setup_factor(" Confirm the only matches are the original methods (which emit final deprecation notice) and upgrade notes regarding removal
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-80995~~ using repository: https://github.com/paulholden/moodle.git

main [branch: MDL-80995 | CI Job]

Error: The ~~MDL-80995~~ branch at https://github.com/paulholden/moodle.git is very old (>60 days ago). Please rebase against current main.

Should these errors be fixed?

Built on: Tue Mar 4 06:06:30 UTC 2025
Show
Fails against automated checks. Checked MDL-80995 using repository: https://github.com/paulholden/moodle.git main [branch: MDL-80995 | CI Job ] Error: The MDL-80995 branch at https://github.com/paulholden/moodle.git is very old (>60 days ago). Please rebase against current main. Should these errors be fixed? Built on: Tue Mar 4 06:06:30 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-80995~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18022/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61571/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61572/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61574/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61576/ App tests (stable app version) --> unrelated app failures

Built on: Wed Jan 22 08:07:46 AM UTC 2025
Show
Launching automatic jobs for branch MDL-80995 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18022/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61571/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61572/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61574/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61576/ App tests (stable app version) --> unrelated app failures Built on: Wed Jan 22 08:07:46 AM UTC 2025

Due to a reworking of the MFA setup, the setup_factor method inside the
tool_mfa\output\renderer class is no longer needed.

Deprecating setup_factor method

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 2 Passed -- (Main)MDL-80995.png
07/Mar/25 4:11 PM
61 kB
Kim Jared Lucas

has been marked as being related by

MDL-79920 Authentication: MFA - Improve user factor setup

Closed

Assignee:: Paul Holden

Reporter:: David Woloszyn

Peer reviewer:: Andrew Lyons

Integrator:: Jun Pataleta

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, David Woloszyn, Jun Pataleta, Kim Jared Lucas, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 21/Feb/24 7:28 AM

Updated:: 11/Apr/25 6:01 PM

Resolved:: 08/Mar/25 12:17 PM

Estimated:

Not Specified

Remaining:

Logged:

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify