Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.10, 4.2.7, 4.3.4
Affects Version/s: 4.4
Component/s: Automated functional tests (behat)
Labels:
- ci
- triaged

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull 4.1 Branch:
~~MDL-80862~~-401
Pull 4.1 Diff URL:
https://github.com/andrewnicols/moodle/compare/4d217e3a1a...MDL-80862-401?w=1
Pull 4.3 Branch:
~~MDL-80862~~-403
Pull 4.3 Diff URL:
https://github.com/andrewnicols/moodle/compare/e4bbd79059...MDL-80862-403?w=1
Pull Main Branch:
~~MDL-80862~~-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/d3ad77e476...MDL-80862-main?w=1
Testing Instructions:
Hide

Grab the patch attached to this issue

Apply it to your site:

git am 0001-NOCOMMIT-Test-scenario-for-MDL-80862.patch

Initialise behat

php admin/tool/behat/cli/init.php

Run behat against the feature (update path to your site):

vendor/bin/behat --config /path/to/yoursite/moodledata_behat/behatrun/behat/behat.yml lib/tests/behat/task.feature

Confirm that 1 scenario passed, and the other failed

2 scenarios (1 passed, 1 failed)
Show
Grab the patch attached to this issue Apply it to your site: git am 0001-NOCOMMIT-Test-scenario-for-MDL-80862.patch Initialise behat php admin/tool/behat/cli/init.php Run behat against the feature (update path to your site): vendor/bin/behat --config /path/to/yoursite/moodledata_behat/behatrun/behat/behat.yml lib/tests/behat/task.feature Confirm that 1 scenario passed, and the other failed 2 scenarios (1 passed, 1 failed)

Discovered during this week's integration cycle, basically the problem happens on a test with task steps such as "I run all adhoc tasks".

If something goes wrong during the task execution, the lock won't be release causing other tests to fail, for example this build: https://ci.moodle.org/job/S.02.01%20-%20Behat%20-%20NonJS%20+%20Postgres/1054/
In the above case "Unexpired and protected data is not removed" scenario also failed caused by the unreleased lock from the task execution on "I can see the room has been created and ready to access" scenario.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) Passed -- (Main)MDL-80862.png
103 kB
22/Feb/24 1:08 PM
0001-NOCOMMIT-Test-scenario-for-MDL-80862.patch
6 kB
20/Feb/24 11:45 AM

has been marked as being related by

MDL-80832 Matrix power level throws error in ad-hoc task

Closed

Assignee:: Andrew Lyons

Reporter:: Simey Lameze

Peer reviewer:: Simey Lameze

Integrator:: Huong Nguyen

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Huong Nguyen, Kim Jared Lucas, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 08/Feb/24 12:19 PM

Updated:: 23/Feb/24 10:34 AM

Resolved:: 23/Feb/24 10:34 AM

Estimated:

Not Specified

Remaining:

Logged:

4h 51m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify