Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80839

Deprecated string still in use

XMLWordPrintable

    • 1
    • HQ2024 Sprint I1.1 Moppies

      I noticed a debugging message in the GHA log. For some reason it does not actually fail unittests

      It looks like the string was deprecated in MDL-80418

      Mdlcode shows that it is still used in two places:

      Debugging: String [addnew,core] is deprecated. Either you should no longer be using that string, or the string has been incorrectly deprecated, in which case you should report this as a bug. Please refer to https://moodledev.io/general/projects/api/string-deprecation
      * line 397 of /lib/classes/string_manager_standard.php: call to debugging()
      * line 6998 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      * line 76 of /lib/classes/output/mustache_string_helper.php: call to get_string()
      * line 66 of /lib/classes/output/mustache_clean_string_helper.php: call to core\output\mustache_string_helper->str()
      * line 54 of /lib/tests/output/mustache_clean_string_helper_test.php: call to core\output\mustache_clean_string_helper->cleanstr()
      * line 1548 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to core\output\mustache_clean_string_helper_test->test_cleanstr()
      * line 1154 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestCase->runTest()
      * line 64 of /lib/phpunit/classes/basic_testcase.php: call to PHPUnit\Framework\TestCase->runBare()
      * line 728 of /vendor/phpunit/phpunit/src/Framework/TestResult.php: call to basic_testcase->runBare()
      * line 904 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestResult->run()
      * line 675 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestCase->run()
      * line 675 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
      * line 675 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
      * line 653 of /vendor/phpunit/phpunit/src/TextUI/TestRunner.php: call to PHPUnit\Framework\TestSuite->run()
      * line 144 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\TestRunner->run()
      * line 97 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\Command->run()
      * line 98 of /vendor/phpunit/phpunit/phpunit: call to PHPUnit\TextUI\Command::main()
      * line 122 of /vendor/bin/phpunit: call to include()
      

        1. deprecation.mp4
          1.50 MB
        2. addnew.png
          addnew.png
          116 kB
        3. (1) Passed -- (Main)MDL-80839.png
          (1) Passed -- (Main)MDL-80839.png
          43 kB

            amaia Amaia Anabitarte
            marina Marina Glancy
            Paul Holden Paul Holden
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 1 minute
                1h 1m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.