Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.3, 5.0
Component/s: Course, Course completion
Labels:

Affected Branches:
MOODLE_403_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
WP-4057
Pull from Repository:
https://github.com/marinaglancy/moodle
Pull Main Branch:
~~MDL-80813~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...marinaglancy:moodle:MDL-80813
Testing Instructions:
Hide

Test 1. Execute the behat test from the description, make sure it passes

Test 2.

Open two sites side by side - one before the patch and one after

Log in as global admin to both sites and open site navigation

Go through each section of site administration and make sure the subsections are in the same order. There is only one exception. The "Plugins -> Cache -> Cache stores" may be the first element in the "Cache" section. That is completely fine.
Show
Test 1. Execute the behat test from the description, make sure it passes Test 2. Open two sites side by side - one before the patch and one after Log in as global admin to both sites and open site navigation Go through each section of site administration and make sure the subsections are in the same order. There is only one exception. The "Plugins -> Cache -> Cache stores" may be the first element in the "Cache" section. That is completely fine.
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-80813~~ using repository: https://github.com/marinaglancy/moodle

main (4 errors / 0 warnings) [branch: MDL-80813 | CI Job]

overview (0/0), phplint (0/0), phpcs (4/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Wed Mar 19 11:03:54 UTC 2025
Show
Fails against automated checks. Checked MDL-80813 using repository: https://github.com/marinaglancy/moodle main (4 errors / 0 warnings) [branch: MDL-80813 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (4/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Wed Mar 19 11:03:54 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-80813~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18843/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64526/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64527/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64528/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64529/ App tests (stable app version)

Built on: Thu Mar 27 16:30:42 UTC 2025
Show
Launching automatic jobs for branch MDL-80813 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18843/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64526/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64527/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64528/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64529/ App tests (stable app version) Built on: Thu Mar 27 16:30:42 UTC 2025

Story Points:
2
Sprint:
WP Sprint 2025-I1.2 (Clones), WP Sprint 2025-I1.3 (Clones), WP Sprint 2025-I1.4 (Clones)

We noticed it while trying to move a setting in Workplace to the new subcategory 'coursedefaultsettings' added in ~~MDL-78530~~

All settings in the 'Courses' category are wrapped in one big "if" statement that checks a presence of one of the 6 specific capabilities:

https://github.com/moodle/moodle/blob/v4.3.0/admin/settings/courses.php#L38

However the settings added to it have different capabilities, for example 'Default completion' is supposed to check capability 'moodle/course:manageactivities', see
https://github.com/moodle/moodle/blob/v4.3.0/admin/settings/courses.php#L268-L272

So basically, if the user only has capability 'moodle/course:manageactivities' but none of the capabilities listed in the beginning of the file, they will not see this item in the site administration. However they will be able to visit the page 'course/defaultcompletion.php' directly.

This applies to several other items, including managing course custom fields, groups settings, etc.

Also all subcategories of 'courses' section (i.e. 'coursedefaultsettings') are also only added if the user has one of these 6 capabilities. The category 'course' is created unconditionally, empty categories are not shown in the site administration

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 3 Passed -- (Main)MDL-80813.png
02/Apr/25 4:27 PM
108 kB
Kim Jared Lucas
MDL-screenshot_20250401-105224.png
01/Apr/25 4:53 PM
28 kB
Ferran Recio

has been marked as being related by

MDL-80842 Reword "Default settings" Course admin section

Open

MDL-78530 Consider the default site completion settings during activity creation

Closed

Assignee:: Marina Glancy

Reporter:: Marina Glancy

Peer reviewer:: Carlos Castillo

Integrator:: Ferran Recio

Tester:: Kim Jared Lucas

Participants:: Carlos Castillo, CiBoT, Ferran Recio, Kim Jared Lucas, Marina Glancy, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 10 Start watching this issue

Created:: 02/Feb/24 6:46 PM

Updated:: 11/Apr/25 5:19 PM

Resolved:: 04/Apr/25 11:43 PM

Estimated:

Remaining:

Logged:

1d 6h 42m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify