Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80670

Improve the way gradebook handles activities which are pending deletion

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.1.6
    • Gradebook
    • MOODLE_401_STABLE

      I can't decide if this is a bug, poor design, or something else...

      When a course module is deleted, it is actually flagged for deletion via the deletioninprogress column in the course modules table. An Ad Hoc task is then scheduled, which does the actual deletion.

      In almost every case, as soon as the deletioninprogress flag is set, the course module is no longer displayed to the user. As far as the user is concerned, the deletion is instant, even though the actual deleting is done later. However, in /grade/report/grader/index.php, course modules which are scheduled for deletion but not yet deleted, are listed with the prefix "[Deletion in progress]" in the column title. This is done in lib/grade/lib.php, function get_name().

      Given that, as far as the user is concerned, the course module has already been deleted, it feels wrong that it still has a column in this table. Shouldn't the column just be omitted entirely if the course module is scheduled for deletion?

      This bug has been exacerbated on our Moodle instance by bug MDL-80594, which caused course modules which were scheduled for deletion, to never actually be deleted. 

            Unassigned Unassigned
            DavidNorman99 David Norman
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.