Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80636

Upgrade HTML Purifier to 4.17.0

XMLWordPrintable

    • MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • MDL-80636-main
    • Hide

      Test 1

      1. Log in as Admin.
      2. Create a Course.
      3. Enrol a Student in the Course.
      4. Create a Forum in the Course.
      5. Log in the Student.
      6. Go to the Forum.
      7. Create a discussion.
      8. In the discussion message, add a couple of HTML links with "Open in new window" checked and a couple with "Open in new window" unchecked.
      9. Save.
      10. View the discussion and verify, viewing source code, that any links that have the "target="xxxx"" attribute will have "rel=noreferrer noopener" attribute added.
      11. Verify when opening a target="_blank" link that the original page is not redirected and the link is open in a new tab/window.
      12. Try the same sort of thing in other text areas and see if any don't add the attribute.

      Example:
      This:

      <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank">Test my link</a>
      

      Becomes:

      <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank" rel="noreferrer noopener">Test my link</a>
      

      Show
      Test 1 Log in as Admin. Create a Course. Enrol a Student in the Course. Create a Forum in the Course. Log in the Student. Go to the Forum. Create a discussion. In the discussion message, add a couple of HTML links with "Open in new window" checked and a couple with "Open in new window" unchecked. Save. View the discussion and verify , viewing source code, that any links that have the " target="xxxx" " attribute will have " rel=noreferrer noopener " attribute added. Verify when opening a target="_blank" link that the original page is not redirected and the link is open in a new tab/window. Try the same sort of thing in other text areas and see if any don't add the attribute. Example: This: < a href = "http://allthethings.co.nz/moodle/redirect.html" target = "_blank" >Test my link</ a > Becomes: < a href = "http://allthethings.co.nz/moodle/redirect.html" target = "_blank" rel = "noreferrer noopener" >Test my link</ a >
    • HQ 2024 Sprint I1.3 Moppies

      HTML Purifier    lib/htmlpurifier/    4.16.0  -->  4.17.0    https://github.com/ezyang/htmlpurifier

        1. (1) 11 Passed -- (Main)MDL-80636.png
          87 kB
          Kim Jared Lucas
        2. (1) 10 Passed -- (Main)MDL-80636.png
          334 kB
          Kim Jared Lucas
        3. (1) 12 Passed -- (Main)MDL-80636.png
          274 kB
          Kim Jared Lucas

            laurent.david@moodle.com Laurent David
            sarjona Sara Arjona (@sarjona)
            Carlos Escobedo Carlos Escobedo
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 10 minutes
                3h 10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.