Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80531

Progress bar displayed when editing large courses

XMLWordPrintable

    • MOODLE_403_STABLE
    • MDL-80531-MOODLE_403_STABLE-progressbar-regrade
    • MDL-80531-master-progressbar-regrade
    • Hide

      1. Create a medium course via Site admin > Development > Make test course

      2. Go to the course and grade one user

      3. Add a graded activity to the course and click "Save and display" (Note that you see the regrading progress bar)

      4. Change the new regrade setting to a number greater than the number of enrolled users, via Site admin > Grades > General settings > regradeprogressbarcount

      5. Go to the course and grade one user

      6. Add a graded activity to the course and click "Save and display" (Note that you don't see the regrading progress bar)

      Show
      1. Create a medium course via Site admin > Development > Make test course 2. Go to the course and grade one user 3. Add a graded activity to the course and click "Save and display" (Note that you see the regrading progress bar) 4. Change the new regrade setting to a number greater than the number of enrolled users, via Site admin > Grades > General settings > regradeprogressbarcount 5. Go to the course and grade one user 6. Add a graded activity to the course and click "Save and display" (Note that you don't see the regrading progress bar)

      In MDL-75878 a progress bar was introduced for large courses when recalculating grades. 

       

      However the limit has rather arbitrarily been set to a limit of 100 activites. 

      https://github.com/sammarshallou/moodle/blob/fbd61d12685069f16ac861261e3b8f0cf913195c/lib/gradelib.php#L354C1-L367C30  

       

      We have not seen any performance issues on our sites and the users are instead annoyed that we are displaying the progress bar. 

       

      Instead we propose moving the limit to a site setting.

      To reproduce:

      1. Create a medium course via Site admin > Development > Make test course
      2. Go to the course and grade one user
      3. Add a graded activity to the course and click "Save and display"
        Note that you see the regrading progress bar

        1. recalculating grades.png
          recalculating grades.png
          399 kB

            Unassigned Unassigned
            tuekorsgaard Tue Korsgaard
            Votes:
            1 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.