Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 4.4.7, 4.5.3
Affects Version/s: 4.1 regressions, 4.1.8, 4.2.5, 4.3.2, 4.5
Component/s: Libraries
Labels:

Affected Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
WP-805
Pull from Repository:
https://github.com/pedrojordao/moodle.git
Pull 4.4 Branch:
~~MDL-80351~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...pedrojordao:moodle:MDL-80351-404
Pull 4.5 Branch:
~~MDL-80351~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...pedrojordao:moodle:MDL-80351-405
Pull Main Branch:
~~MDL-80351~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...pedrojordao:moodle:MDL-80351
Testing Instructions:

Hide

1. Login as admin
2. Create a new course and add a URL activity
3. Check `Students must manually mark the activity as done` under `Completion conditions`
4. Save the changes
5. Create one student and enroll it in the course.
6. Log in as the new student and complete the URL activity to generate data
7. Login as admin
8. Go to the Course Participants tab
9. Go to the Student profile page by clicking on its name
10. Click on `All logs`
11. Confirm the chart loaded and the y-axis label 'Hits' was displayed.

Show
1. Login as admin 2. Create a new course and add a URL activity 3. Check `Students must manually mark the activity as done` under `Completion conditions` 4. Save the changes 5. Create one student and enroll it in the course. 6. Log in as the new student and complete the URL activity to generate data 7. Login as admin 8. Go to the Course Participants tab 9. Go to the Student profile page by clicking on its name 10. Click on `All logs` 11. Confirm the chart loaded and the y-axis label 'Hits' was displayed.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-80351~~ using repository: https://github.com/pedrojordao/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-80351-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-80351-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-80351 | CI Job]

_{More information about this report}

Built on: Thu Feb 13 04:09:34 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-80351 using repository: https://github.com/pedrojordao/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-80351-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-80351-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-80351 | CI Job ] More information about this report Built on: Thu Feb 13 04:09:34 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-80351~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18257/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62395/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62396/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-80351~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18258/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62397/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62398/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-80351~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18259/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62399/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62400/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62401/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62402/ App tests (stable app version)

Built on: Thu Feb 13 04:25:25 PM UTC 2025
Show
Launching automatic jobs for branch MDL-80351 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18257/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62395/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62396/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-80351 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18258/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62397/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62398/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-80351 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18259/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62399/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62400/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62401/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62402/ App tests (stable app version) Built on: Thu Feb 13 04:25:25 PM UTC 2025

Story Points:
1
Sprint:
WP Sprint 2024-I4.3 (Clones), WP Sprint 2025-I1.0 (Clones), WP Sprint 2025-I1.1 (Clones), WP Sprint 2025-I1.2 (Clones)

The Chart API has options for axes such as set_label() and set_stepsize(). These appear to have stopped working in Moodle 4.1 onwards.

The steps below show that the y-axis label is not set. In my tests set_stepsize() doesn't work either.

Steps to reproduce issue

Create a course. (Steps 1 and 2 can be skipped by logging into https://sandbox.moodledemo.net as teacher and going to My first course).
Enrol a student.
From the course participants page click on the student then click on All logs (under Reports).

Expected results

The y-axis has the label 'Hits'.

Actual results

The y-axis has no label. If you try these steps with Moodle 4.0 the label appears as expected (for example, on https://sandbox400.moodledemo.net).

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-80351.png
119 kB
27/Feb/25 1:02 PM

has a non-specific relationship to

MDL-78365 Choice - UI of chart of result in Choice is broken.

Closed

has to be done after

MDL-83737 Upgrade Chart.js to latest version

Closed

is a regression caused by

MDL-71708 Upgrade Chart.js to 3.8.0

Closed

links to

ChartJS 3.x Migration Guide

Assignee:: Pedro Jordao

Reporter:: Leon Stringer

Peer reviewer:: Paul Holden

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Huong Nguyen, Leon Stringer, Paul Holden, Pedro Jordao, Ron Carl Alfon Yu

Votes:: 2 Vote for this issue

Watchers:: 14 Start watching this issue

Created:: 07/Dec/23 6:46 PM

Updated:: 17/Mar/25 9:20 AM

Resolved:: 28/Feb/25 12:56 AM

Estimated:

Remaining:

Logged:

2d 2h 17m

Details

Description

Steps to reproduce issue

Expected results

Actual results

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify