Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.9, 4.2.6, 4.3.3
Affects Version/s: 3.9.24, 3.11.17, 4.1.6, 4.2.3, 4.3 regressions, 4.3.1
Component/s: General
Labels:

Affected Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
Pull from Repository:
https://github.com/davewoloszyn/moodle.git
Pull 4.1 Branch:
~~MDL-80229~~-401
Pull 4.1 Diff URL:
https://github.com/davewoloszyn/moodle/compare/94ad185d09...MDL-80229-401
Pull 4.3 Branch:
~~MDL-80229~~-403
Pull 4.3 Diff URL:
https://github.com/davewoloszyn/moodle/compare/72d7395c96...MDL-80229-403
Pull Main Branch:
~~MDL-80229~~-main
Pull Main Diff URL:
https://github.com/davewoloszyn/moodle/compare/b58d1fd4e2...MDL-80229-main
Testing Instructions:

Hide

Testing is difficult to provide. This issue only affects a small window of time at the time of packaging.

The minimum revision value is based on a moving target from $version inside version.php and to trigger an error, you would need to have a current time more than two days before the value in $version.

The more testable cases of min_get_minimum_revision() and friends is covered in lib/tests/configonlylib_test.php

Show
Testing is difficult to provide. This issue only affects a small window of time at the time of packaging. The minimum revision value is based on a moving target from $version inside version.php and to trigger an error, you would need to have a current time more than two days before the value in $version. The more testable cases of min_get_minimum_revision() and friends is covered in lib/tests/configonlylib_test.php

Story Points:
1
Sprint:
Team Hedgehog 2023 Sprint 4.2, Team Hedgehog 2023 Sprint 4.3, Team Hedgehog 2023 Review 4
Issue size:
Small

A regression from MDL-77846 saw that packaging before the release date caused an error during that window.

This is because we take the date in version.php and compare it to the current date. We assume that the current date is some time after the date in version.php, but this is not the case at time of packaging.

Let's introduce a tolerance of 48 hours to avoid these errors.

Assignee:: David Woloszyn

Reporter:: David Woloszyn

Peer reviewer:: Meirza

Integrator:: Huong Nguyen

Tester:: CiBoT

Participants:: CiBoT, David Woloszyn, Huong Nguyen, Ilya Tregubov, Meirza

Votes:: 0 Vote for this issue

Watchers:: 10 Start watching this issue

Created:: 23/Nov/23 2:00 PM

Updated:: 12/Jan/24 10:02 AM

Resolved:: 12/Jan/24 10:02 AM

Estimated:

Remaining:

Logged:

2h 21m

Details

Description

Attachments

Activity

People

Dates

Time Tracking

Clockify