Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79756

Remove usage of master and slave in core/checkbox-toggleall

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 5.1
    • 4.4
    • JavaScript
    • MOODLE_404_STABLE
    • MOODLE_501_STABLE
    • MDL-79756-main
    • Hide

      Choice activity

      Prerequisites
      1. A course with at least one teacher and two students.
      2. A Choice activity in a course with the following settings:
        • Has at least two options.
        • Publish results: Always show results to students.
        • Privacy of results: Publish full results, showing names and their choices.
        • "Show column for unanswered": Yes.
      Test
      1. Login as a teacher.
      2. Go to the choice activity.
      3. Below the Responses table, confirm that there is a "Select all" button.
      4. Click on it.
      5. Confirm that the checkboxes beside each participant in the responses table are checked.
      6. Confirm that its text becomes "Deselect all"
      7. Click on "Deselect all"
      8. Confirm that the checkboxes beside each participant in the responses table become unchecked.
      9. Check/uncheck the checkboxes right under each column header
      10. Confirm that the checkboxes under the same column are checked when the column header checkbox is checked.
      11. Confirm that when the column header checkbox gets unchecked, the checkboxes under the same column also get checked.
      12. Tick all of the items under a column.
      13. Confirm that the checkbox under the column header also gets checked.
      14. Untick one or more items under a column.
      15. Confirm that the checkbox under the column header also gets unchecked.
      16. Click the "Select all" button again
      17. Untick one of the items
      18. Confirm that the Deselect all" button's label becomes "Select all"
      19. Check the state of the "With selected" select box.
      20. Confirm that when no items are selected, the select box is disabled.
      21. Confirm that when at least one item is selected, the select box becomes enabled.

      Bulk user actions

      1. Repeat the testing of MDL-80548 and confirm that everything still works as expected.

      Gradebook setup

      1. Repeat the testing of MDL-65948 and confirm that everything still works as expected.

      Tags

      1. Log in as an admin
      2. Go to "Site administration > Appearance > Manage tags"
      3. Click on the "Default collection"
      4. Confirm that the "Select all" checkbox (checkbox on the table header) toggles all of the checkboxes for the entries.
      5. Confirm that deselecting a checkbox in any of the rows toggles off the tick on the "Select all" checkbox.
      6. Confirm that selecting all checkboxes in the list of entries selects toggles the tick on the "Select all" checkbox back on.

      File manager

      1. Repeat the testing for MDL-79927 and confirm that everything still works as expected.

      Database activity

      1. Create a database activity
      2. Use any preset
      3. On the Templates page, select "List view template" and add ##delcheck## to the "Repeated entry" template.
      4. Save the changes.
      5. Add at least two entries.
      6. Go to the list view
      7. You should see a checkbox on each entry
      8. Confirm that pressing "Select all" selects all checkboxes in the entries.
      9. Confirm that it changes to "Deselect all" and clicking on "Deselect all" deselect all entries.
      10. Confirm that selecting at least one entry activates the "Delete selected" button and that selecting none deactivates it.

      Feedback activity

      1. Repeat the testing for MDL-65935 and confirm that everything still works as expected.

      Forum bulk actions

      1. Check out the forum bulk actions feature introduced in MDL-66298 and confirm that the checkbox selection still works as expected in the forum summary report

      Lesson

      1. Repeat the testing for MDL-65937 and confirm that everything still works as expected.

      Quiz

      1. Repeat the testing for MDL-65938 and confirm that everything still works as expected.

      SCORM

      1. Repeat the testing for MDL-65946 and confirm that everything still works as expected.

      Question bank

      1. Repeat the testing for MDL-65994 and confirm that everything still works as expected.

      Analytics

      1. Check out MDL-62191 and confirm that the bulk selection of entries in the insights report still works as expected.

      Participation report

      1. Repeat the testing for MDL-65949 and confirm that everything still works as expected.

      Repository

      1. Check out MDL-33671 and confirm that the bulk selection of files in the private files repository still works as expected.

      Course participants page

      1. Repeat the testing for MDL-65950 and confirm that everything still works as expected.
      Show
      Choice activity Prerequisites A course with at least one teacher and two students. A Choice activity in a course with the following settings: Has at least two options. Publish results: Always show results to students. Privacy of results: Publish full results, showing names and their choices. " Show column for unanswered ": Yes. Test Login as a teacher. Go to the choice activity. Below the Responses table, confirm that there is a " Select all " button. Click on it. Confirm that the checkboxes beside each participant in the responses table are checked. Confirm that its text becomes " Deselect all " Click on "Deselect all" Confirm that the checkboxes beside each participant in the responses table become unchecked. Check/uncheck the checkboxes right under each column header Confirm that the checkboxes under the same column are checked when the column header checkbox is checked. Confirm that when the column header checkbox gets unchecked, the checkboxes under the same column also get checked. Tick all of the items under a column. Confirm that the checkbox under the column header also gets checked. Untick one or more items under a column. Confirm that the checkbox under the column header also gets unchecked. Click the " Select all " button again Untick one of the items Confirm that the Deselect all " button's label becomes "Select all" Check the state of the " With selected " select box. Confirm that when no items are selected, the select box is disabled. Confirm that when at least one item is selected, the select box becomes enabled. Bulk user actions Repeat the testing of MDL-80548 and confirm that everything still works as expected. Gradebook setup Repeat the testing of MDL-65948 and confirm that everything still works as expected. Tags Log in as an admin Go to " Site administration > Appearance > Manage tags " Click on the " Default collection " Confirm that the " Select all " checkbox (checkbox on the table header) toggles all of the checkboxes for the entries. Confirm that deselecting a checkbox in any of the rows toggles off the tick on the " Select all " checkbox. Confirm that selecting all checkboxes in the list of entries selects toggles the tick on the " Select all " checkbox back on. File manager Repeat the testing for MDL-79927 and confirm that everything still works as expected. Database activity Create a database activity Use any preset On the Templates page, select "List view template" and add ##delcheck## to the " Repeated entry " template. Save the changes. Add at least two entries. Go to the list view You should see a checkbox on each entry Confirm that pressing " Select all " selects all checkboxes in the entries. Confirm that it changes to " Deselect all " and clicking on " Deselect all " deselect all entries. Confirm that selecting at least one entry activates the " Delete selected " button and that selecting none deactivates it. Feedback activity Repeat the testing for MDL-65935 and confirm that everything still works as expected. Forum bulk actions Check out the forum bulk actions feature introduced in MDL-66298 and confirm that the checkbox selection still works as expected in the forum summary report Lesson Repeat the testing for MDL-65937 and confirm that everything still works as expected. Quiz Repeat the testing for MDL-65938 and confirm that everything still works as expected. SCORM Repeat the testing for MDL-65946 and confirm that everything still works as expected. Question bank Repeat the testing for MDL-65994 and confirm that everything still works as expected. Analytics Check out MDL-62191 and confirm that the bulk selection of entries in the insights report still works as expected. Participation report Repeat the testing for MDL-65949 and confirm that everything still works as expected. Repository Check out MDL-33671 and confirm that the bulk selection of files in the private files repository still works as expected. Course participants page Repeat the testing for MDL-65950 and confirm that everything still works as expected.
    • Hide

      Code verified against automated checks with warnings.

      Checked MDL-79756 using repository: https://github.com/junpataleta/moodle.git

      Should these errors be fixed?

      Built on: Wed Mar 12 08:20:13 UTC 2025

      Show
      Code verified against automated checks with warnings. Checked MDL-79756 using repository: https://github.com/junpataleta/moodle.git main (0 errors / 2 warnings) [branch: MDL-79756-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/2) , gherkin (0/0) , Should these errors be fixed? Built on: Wed Mar 12 08:20:13 UTC 2025
    • Show
      Launching automatic jobs for branch MDL-79756 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18531/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63474/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63475/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63476/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63477/ App tests (stable app version) --> unrelated app failure, please ignore. Built on: Wed Mar 12 02:25:14 UTC 2025

      We need better and more inclusive wordings for the checkboxes in pages that use the core/checkbox-toggleall module.

      Possible alternatives for the "master" and "slave" checkboxes:

      • "parent" and "child" checkboxes
      • "controller" and "target" checkboxes

        1. (1) 10 Passed -- (Main)MDL-79756.png
          (1) 10 Passed -- (Main)MDL-79756.png
          121 kB
        2. (1) 11 Passed -- (Main)MDL-79756.png
          (1) 11 Passed -- (Main)MDL-79756.png
          103 kB
        3. (1) 13 Passed -- (Main)MDL-79756.png
          (1) 13 Passed -- (Main)MDL-79756.png
          102 kB
        4. (1) 15 Passed -- (Main)MDL-79756.png
          (1) 15 Passed -- (Main)MDL-79756.png
          106 kB
        5. (1) 18 Passed -- (Main)MDL-79756.png
          (1) 18 Passed -- (Main)MDL-79756.png
          108 kB
        6. (1) 20 Passed -- (Main)MDL-79756.png
          (1) 20 Passed -- (Main)MDL-79756.png
          106 kB
        7. (1) 21 Passed -- (Main)MDL-79756.png
          (1) 21 Passed -- (Main)MDL-79756.png
          107 kB
        8. (1) 3 Passed -- (Main)MDL-79756.png
          (1) 3 Passed -- (Main)MDL-79756.png
          97 kB
        9. (1) 6 Passed -- (Main)MDL-79756.png
          (1) 6 Passed -- (Main)MDL-79756.png
          108 kB
        10. (1) 8 Passed -- (Main)MDL-79756.png
          (1) 8 Passed -- (Main)MDL-79756.png
          111 kB
        11. (2) MDL-80548 Passed -- (Main)MDL-79756.png
          (2) MDL-80548 Passed -- (Main)MDL-79756.png
          65 kB
        12. (3) MDL-65948 Passed -- (Main)MDL-79756.png
          (3) MDL-65948 Passed -- (Main)MDL-79756.png
          143 kB
        13. (4) 6 Passed -- (Main)MDL-79756.png
          (4) 6 Passed -- (Main)MDL-79756.png
          76 kB
        14. (5) MDL-79927 Passed -- (Main)MDL-79756.png
          (5) MDL-79927 Passed -- (Main)MDL-79756.png
          1.11 MB
        15. (6) 10 Passed -- (Main)MDL-79756.png
          (6) 10 Passed -- (Main)MDL-79756.png
          1.49 MB
        16. (7) MDL-65935 Passed -- (Main)MDL-79756.png
          (7) MDL-65935 Passed -- (Main)MDL-79756.png
          222 kB
        17. (8) MDL-66298 Passed -- (Main)MDL-79756.png
          (8) MDL-66298 Passed -- (Main)MDL-79756.png
          1.25 MB
        18. (9) MDL-65937 Passed -- (Main)MDL-79756.png
          (9) MDL-65937 Passed -- (Main)MDL-79756.png
          298 kB
        19. Bug_MDL-65946_Step5_(Main MDL-79756).png
          Bug_MDL-65946_Step5_(Main MDL-79756).png
          158 kB
        20. MDL-33671_1(Main MDL-79756).png
          MDL-33671_1(Main MDL-79756).png
          90 kB
        21. MDL-33671_2(Main MDL-79756).png
          MDL-33671_2(Main MDL-79756).png
          80 kB
        22. MDL-33671_3(Main MDL-79756).png
          MDL-33671_3(Main MDL-79756).png
          80 kB
        23. MDL-62191_1(Main MDL-79756).png
          MDL-62191_1(Main MDL-79756).png
          66 kB
        24. MDL-62191_2(Main MDL-79756).png
          MDL-62191_2(Main MDL-79756).png
          68 kB
        25. MDL-62191_3(Main MDL-79756).png
          MDL-62191_3(Main MDL-79756).png
          66 kB
        26. MDL-65938_Editing_quiz_Step11(Main MDL-79756).png
          MDL-65938_Editing_quiz_Step11(Main MDL-79756).png
          91 kB
        27. MDL-65938_Editing_quiz_Step4(Main MDL-79756).png
          MDL-65938_Editing_quiz_Step4(Main MDL-79756).png
          91 kB
        28. MDL-65938_Editing_quiz_Step7(Main MDL-79756).png
          MDL-65938_Editing_quiz_Step7(Main MDL-79756).png
          91 kB
        29. MDL-65938_Editing_quiz_Step9(Main MDL-79756).png
          MDL-65938_Editing_quiz_Step9(Main MDL-79756).png
          91 kB
        30. MDL-65938_Overview_Step10.1(Main MDL-79756).png
          MDL-65938_Overview_Step10.1(Main MDL-79756).png
          168 kB
        31. MDL-65938_Overview_Step10.2(Main MDL-79756).png
          MDL-65938_Overview_Step10.2(Main MDL-79756).png
          168 kB
        32. MDL-65938_Overview_Step11_Error(Main MDL-79756).png
          MDL-65938_Overview_Step11_Error(Main MDL-79756).png
          109 kB
        33. MDL-65938_Overview_Step12.1(Main MDL-79756).png
          MDL-65938_Overview_Step12.1(Main MDL-79756).png
          81 kB
        34. MDL-65938_Overview_Step12.2_error(Main MDL-79756).png
          MDL-65938_Overview_Step12.2_error(Main MDL-79756).png
          81 kB
        35. MDL-65938_Overview_Step8.1(Main MDL-79756).png
          MDL-65938_Overview_Step8.1(Main MDL-79756).png
          168 kB
        36. MDL-65938_Overview_Step8.2(Main MDL-79756).png
          MDL-65938_Overview_Step8.2(Main MDL-79756).png
          170 kB
        37. MDL-65938_Responses_report_Step11.1(Main MDL-79756).png
          MDL-65938_Responses_report_Step11.1(Main MDL-79756).png
          51 kB
        38. MDL-65938_Responses_report_Step11.2(Main MDL-79756).png
          MDL-65938_Responses_report_Step11.2(Main MDL-79756).png
          51 kB
        39. MDL-65938_Responses_report_Step12(Main MDL-79756).png
          MDL-65938_Responses_report_Step12(Main MDL-79756).png
          84 kB
        40. MDL-65938_Responses_report_Step4(Main MDL-79756).png
          MDL-65938_Responses_report_Step4(Main MDL-79756).png
          58 kB
        41. MDL-65938_Responses_report_Step7.1(Main MDL-79756).png
          MDL-65938_Responses_report_Step7.1(Main MDL-79756).png
          174 kB
        42. MDL-65938_Responses_report_Step7.2(Main MDL-79756).png
          MDL-65938_Responses_report_Step7.2(Main MDL-79756).png
          173 kB
        43. MDL-65938_Responses_report_Step9(Main MDL-79756).png
          MDL-65938_Responses_report_Step9(Main MDL-79756).png
          173 kB
        44. MDL-65946_BasicReport_1(Main MDL-79756).png
          MDL-65946_BasicReport_1(Main MDL-79756).png
          81 kB
        45. MDL-65946_BasicReport_2(Main MDL-79756).png
          MDL-65946_BasicReport_2(Main MDL-79756).png
          66 kB
        46. MDL-65946_BasicReport_3(Main MDL-79756).png
          MDL-65946_BasicReport_3(Main MDL-79756).png
          66 kB
        47. MDL-65946_Interactions_1(Main MDL-79756).png
          MDL-65946_Interactions_1(Main MDL-79756).png
          121 kB
        48. MDL-65946_Interactions_2(Main MDL-79756).png
          MDL-65946_Interactions_2(Main MDL-79756).png
          121 kB
        49. MDL-65946_Objectives_1(Main MDL-79756).png
          MDL-65946_Objectives_1(Main MDL-79756).png
          121 kB
        50. MDL-65946_Objectives_2(Main MDL-79756).png
          MDL-65946_Objectives_2(Main MDL-79756).png
          121 kB
        51. MDL-65949_1(Main MDL-79756).png
          MDL-65949_1(Main MDL-79756).png
          57 kB
        52. MDL-65949_2(Main MDL-79756).png
          MDL-65949_2(Main MDL-79756).png
          55 kB
        53. MDL-65949_3(Main MDL-79756).png
          MDL-65949_3(Main MDL-79756).png
          55 kB
        54. MDL-65949_4(Main MDL-79756).png
          MDL-65949_4(Main MDL-79756).png
          64 kB
        55. MDL-65950_1(Main MDL-79756).png
          MDL-65950_1(Main MDL-79756).png
          201 kB
        56. MDL-65950_2(Main MDL-79756).png
          MDL-65950_2(Main MDL-79756).png
          201 kB
        57. MDL-65950_3(Main MDL-79756).png
          MDL-65950_3(Main MDL-79756).png
          64 kB
        58. MDL-65994_EditQuiz_1(Main MDL-79756).png
          MDL-65994_EditQuiz_1(Main MDL-79756).png
          178 kB
        59. MDL-65994_EditQuiz_2(Main MDL-79756)
          178 kB
        60. MDL-65994_EditQuiz_3(Main MDL-79756).png
          MDL-65994_EditQuiz_3(Main MDL-79756).png
          176 kB
        61. MDL-65994_QuestionBank_11.1(Main MDL-79756).png
          MDL-65994_QuestionBank_11.1(Main MDL-79756).png
          68 kB
        62. MDL-65994_QuestionBank_11.2(Main MDL-79756).png
          MDL-65994_QuestionBank_11.2(Main MDL-79756).png
          68 kB
        63. MDL-65994_QuestionBank_7.1(Main MDL-79756).png
          MDL-65994_QuestionBank_7.1(Main MDL-79756).png
          200 kB
        64. MDL-65994_QuestionBank_7.2(Main MDL-79756).png
          MDL-65994_QuestionBank_7.2(Main MDL-79756).png
          198 kB
        65. MDL-79756_Editing_quiz_step3(Main MDL-79756).png
          MDL-79756_Editing_quiz_step3(Main MDL-79756).png
          91 kB
        66. MDL-79756_Editing_quiz_test_step6(Main MDL-79756).png
          MDL-79756_Editing_quiz_test_step6(Main MDL-79756).png
          92 kB
        67. quiz_report_checkbox_alignment.png
          quiz_report_checkbox_alignment.png
          78 kB

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Luca Bösch Luca Bösch
            Huong Nguyen Huong Nguyen
            Raquel Ortega Raquel Ortega
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 5 hours, 30 minutes
                1d 5h 30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.