Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79680

Upgrade PrismJS to 1.29.0

XMLWordPrintable

    • MOODLE_405_STABLE
    • MOODLE_405_STABLE
    • MDL-79680_upgrade-prismjs
    • Hide

      Instructions copied from MDL-75963.

      Verify lib version

      1. Access to "Site administration / Development / Third party libraries".
      2. Verify third-party lib versions for PrismJs is 1.29.0

      Verify important upgrade steps were followed

      1. Verify the following command returns no results

        grep 'code\[class\*="language-"\]' filter/codehighlighter/styles.css 

      Verify code highlighting works

      1. Log in as admin.
      2. Navigate to Manage Filters in Site Admin
      3. Verify that you see "Code Highlighter" in the filter table, and enable the filter.
      4. Choose TinyMCE as your text editor by navigating to Editor Preferences.
      5. Navigate to Edit Profile.
      6. In the description input, fill in the text "This code text should be red".
      7. Block the text. Click Format on the menu and select Code.
      8. Verify that the text colour turns red.
      9. Click the Update Profile button.
      10. Navigate to your Profile page.
      11. Verify that the text is displayed in the same style as the TinyMCE editor.
      12. Navigate to Edit Profile.
      13. Create a new line at the bottom of the previous text in the description input.
      14. Click Insert on the menu and select Code Sample.
      15. Select "PHP" in the language dropdown.
      16. In the code view, fill in the text below:

        <?php
        defined('MOODLE_INTERNAL') || die();
        ?>

      17. Click the Save button.
      18. Verify if you see the code written with the code highlighter display.
      19. Click the Update Profile button.
      20. Navigate to your Profile page.
      21. Verify that the profile description has the text "This code text should be red" and the PHP line of codes with the same look/style as the TinyMCE editor.
      Show
      Instructions copied from MDL-75963 . Verify lib version Access to "Site administration / Development / Third party libraries". Verify third-party lib versions for PrismJs is 1.29.0 Verify important upgrade steps were followed Verify the following command returns no results grep 'code\[class\*="language-"\]' filter /codehighlighter/styles .css Verify code highlighting works Log in as admin. Navigate to Manage Filters in Site Admin Verify that you see "Code Highlighter" in the filter table, and enable the filter. Choose TinyMCE as your text editor by navigating to Editor Preferences. Navigate to Edit Profile. In the description input, fill in the text "This code text should be red". Block the text. Click Format on the menu and select Code. Verify that the text colour turns red. Click the Update Profile button. Navigate to your Profile page. Verify that the text is displayed in the same style as the TinyMCE editor. Navigate to Edit Profile. Create a new line at the bottom of the previous text in the description input. Click Insert on the menu and select Code Sample. Select "PHP" in the language dropdown. In the code view, fill in the text below: <?php defined( 'MOODLE_INTERNAL' ) || die(); ?> Click the Save button. Verify if you see the code written with the code highlighter display. Click the Update Profile button. Navigate to your Profile page. Verify that the profile description has the text "This code text should be red" and the PHP line of codes with the same look/style as the TinyMCE editor.

      PrismJS    filter/codehighlighter/amd/src/prism.js    1.16.0  -->  1.29.0    https://github.com/PrismJS/prism

            Daniel Ziegenberg Daniel Ziegenberg
            sarjona Sara Arjona (@sarjona)
            David Woloszyn David Woloszyn
            Jun Pataleta Jun Pataleta
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 36 minutes
                1h 36m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.