Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 4.4.9, 4.5.5, 5.0.1
Affects Version/s: 4.1.5, 4.3, 4.3.8, 4.4.4, 4.5
Component/s: Assignment, Grading methods
Labels:
- ci
- patch
- release_notes
- triaged

Affected Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/mihailges/moodle.git
Pull 4.4 Branch:
~~MDL-79464~~-404
Pull 4.4 Diff URL:
https://github.com/mihailges/moodle/compare/3101137de3...MDL-79464-404?w=1
Pull 4.5 Branch:
~~MDL-79464~~-405
Pull 4.5 Diff URL:
https://github.com/mihailges/moodle/compare/44fabe1c3d...MDL-79464-405?w=1
Pull Main Branch:
~~MDL-79464~~-main
Pull Main Diff URL:
https://github.com/mihailges/moodle/compare/e3b05240c1...MDL-79464-main?w=1
Testing Instructions:
Hide

Create a course with a teacher and two enrolled students

Add an assignment to the course and configure it to use a marking guide

Add a marking guide to the assignment, with a couple of criterions that have 50 for maximum score

Sign in as the teacher and navigate to the grading screen

Enter feedback and a score for Criterion 1, but not Criterion 2, save changes and verify that a red warning "toast" alert is posted to the top of the screen and remains visible for 4 seconds

Attempt to change user by clicking on the "next" arrow in the top right and verify that a modal warning the user about losing unsaved work appears

Click on "Save and continue" and observe that the grading panel is reloaded and the alert reiterated

Add a remark and score for Criterion 2 and verify that the grade now saves successfully|

Attempt again to navigate to the next user and observe that this now works
Show
Create a course with a teacher and two enrolled students Add an assignment to the course and configure it to use a marking guide Add a marking guide to the assignment, with a couple of criterions that have 50 for maximum score Sign in as the teacher and navigate to the grading screen Enter feedback and a score for Criterion 1, but not Criterion 2, save changes and verify that a red warning "toast" alert is posted to the top of the screen and remains visible for 4 seconds Attempt to change user by clicking on the "next" arrow in the top right and verify that a modal warning the user about losing unsaved work appears Click on "Save and continue" and observe that the grading panel is reloaded and the alert reiterated Add a remark and score for Criterion 2 and verify that the grade now saves successfully| Attempt again to navigate to the next user and observe that this now works
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-79464~~ using repository: https://github.com/mihailges/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-79464-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-79464-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-79464-main | CI Job]

_{More information about this report}

Built on: Thu Apr 10 08:59:04 UTC 2025
Show
Code verified against automated checks. Checked MDL-79464 using repository: https://github.com/mihailges/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-79464-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-79464-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-79464-main | CI Job ] More information about this report Built on: Thu Apr 10 08:59:04 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-79464~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18592/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63693/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63694/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-79464~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18593/ PHPUnit (sqlsrv) --> random failure, please ignore.

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63695/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63696/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-79464~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18594/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63697/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63698/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63699/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63700/ App tests (stable app version) --> unrelated app failure, please ignore.

Built on: Fri Mar 14 10:30:22 UTC 2025
Show
Launching automatic jobs for branch MDL-79464 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18592/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63693/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63694/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-79464 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18593/ PHPUnit (sqlsrv) --> random failure, please ignore. https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63695/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63696/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-79464 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18594/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63697/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63698/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63699/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63700/ App tests (stable app version) --> unrelated app failure, please ignore. Built on: Fri Mar 14 10:30:22 UTC 2025

On the assignment activity. Particularly when using advanced grading (e.g. rubrics) if user attempts to save but the save fails, it is not clear that the failure happens and the error message is not focussed so easily missed. The user can then navigate away from the grading screen without any warning that the work will be lost and thereby losing all grading and feedback.

Reproduce:

Create a course with 1 teacher and 2 students
as teacher, create an assignment activity and enable a rubric with some criteria and feedback comments
as a teacher, attempt to grade the student, but only partially complete the rubric.
Add some feedback comments
Click save.
There is no visual indication of failure of the save and the red validation text on the rubric is not brought into focus
navigate to student 2 and observe that no warning is given before leaving the page
return to student 1 and observe that all the grading added has been lost.

Also confirmed on 4.3 on qa.moodle.net

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-79464.png
16/Apr/25 10:44 AM
362 kB
Ron Carl Alfon Yu

is duplicated by

MDL-79983 Rubric saving leads to loss of data

Closed

Assignee:: Alec Gullon

Reporter:: Tim Ellis

Peer reviewer:: Mihail Geshoski

Integrator:: Glyn (Mathew) May

Tester:: Ron Carl Alfon Yu

Participants:: Alec Gullon, CiBoT, Glyn (Mathew) May, Helen Foster, Mihail Geshoski, Richard van Iwaarden, Ron Carl Alfon Yu, Sara Arjona (@sarjona), Tim Ellis, Tony Butler

Votes:: 5 Vote for this issue

Watchers:: 14 Start watching this issue

Created:: 22/Sep/23 4:30 PM

Updated:: 05/Jun/25 12:01 AM

Resolved:: 17/Apr/25 8:57 PM

Estimated:

Remaining:

Logged:

4h 36m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify