-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
4.4
-
MOODLE_404_STABLE
See MDL-79373 (& MDL-74489 & MDL-78961...) regarding the current hardcoding of known password config and the potential problems associated with that:
- Easy for it to become out of sync (when new password configuration is added)
- Easy for typos
- We can end up unintentionally exposing site passwords in shared preset files, despite the admin asking that they be excluded (thanks michaelh!)
- No default support for third-party plugins (relies on the admin knowing such config exists and manually editing the settings) above
- Related to the above, it's a clear breach of our inter-component communication rules (core should not have or require any knowledge of installed components)
We should have a better way of implementing this - an obvious solution would appear to be to treat all configuration of type admin_setting_configpasswordunmask or admin_setting_requiredpasswordunmask as "sensitive", removing the onus on the admin to define them. This would also mean third-party plugins would get automatic support too
We could then leave the current textbox configuration for any additional settings the admin wants to consider as sensitive (e.g. the salt values[*] we added in MDL-74489)
[*] We might also ask why the salt configuration are not password fields themselves - perhaps they should be, but that may be beyond the focus of this ticket
- has a non-specific relationship to
-
MDL-78536 Admin presets treat settings as incorrect types
-
- Open
-