Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79204

Trailing slash on HTML tags causing code check fails for course format plugins

XMLWordPrintable

      Course format plugins are failing code checks (both GitHub CI and code prechecks) due to HTML tag trailing slashes in included Mustache files. See:
      GitHub CI https://github.com/james-cnz/moodle-format_multitopic/actions/runs/5803629796/job/15732009471
      Code prechecks https://moodle.org/plugins/format_multitopic/v4.2.3-rc1/29755?smurf=html#mustache

      I think these are the relevant files:
      course/format/templates/local/content/cm/bulkselect.mustache
      course/format/templates/local/content/section/bulkselect.mustache

      Really I think the problem is overly stringent checking, I don't think there's really anything wrong with HTML tag trailing slashes.  However, I've raised issues with the checkers, and aren't sure when or if it will be changed there. See:
      https://github.com/moodlehq/moodle-local_ci/pull/274
      https://tracker.moodle.org/browse/MDLSITE-7329

      Removing the trailing slashes should resolve the issue, and it would be nice to be able to pass the checks again.

      Cheers,
      James

            james-cnz James E. Calder
            james-cnz James E. Calder
            Dan Marsden Dan Marsden
            Andrew Lyons Andrew Lyons
            Andrew Lyons Andrew Lyons
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.