-
Bug
-
Resolution: Fixed
-
Minor
-
4.2
-
MOODLE_402_STABLE
-
MOODLE_402_STABLE
-
mdl-79204-master
-
Easy
-
Course format plugins are failing code checks (both GitHub CI and code prechecks) due to HTML tag trailing slashes in included Mustache files. See:
GitHub CI https://github.com/james-cnz/moodle-format_multitopic/actions/runs/5803629796/job/15732009471
Code prechecks https://moodle.org/plugins/format_multitopic/v4.2.3-rc1/29755?smurf=html#mustache
I think these are the relevant files:
course/format/templates/local/content/cm/bulkselect.mustache
course/format/templates/local/content/section/bulkselect.mustache
Really I think the problem is overly stringent checking, I don't think there's really anything wrong with HTML tag trailing slashes. However, I've raised issues with the checkers, and aren't sure when or if it will be changed there. See:
https://github.com/moodlehq/moodle-local_ci/pull/274
https://tracker.moodle.org/browse/MDLSITE-7329
Removing the trailing slashes should resolve the issue, and it would be nice to be able to pass the checks again.
Cheers,
James
- duplicates
-
MDL-78809 Remove trailing slash in favicon link in head.mustache
-
- Development in progress
-
- has a non-specific relationship to
-
MDLSITE-7329 In Moodle plugin code prechecks, Mustache "info" messages are treated as warnings
-
- Open
-
-
MDL-76783 Course bulk edit: The basic bulk section and activity selection UI, no actions yet
-
- Closed
-