Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79076

Migrate callback 'before_standard_html_head' to a hook

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_404_STABLE
    • MDL-79076-master-2
    • Hide

      Policy

      • already covered by behat tests

      Mobile

      • Enable $CFG->enablemobilewebservice and tool_mobile/enablesmartappbanners ; make sure you have set up tool_mobile/androidappid and tool_mobile/iosappid (you can put anything there, it does not matter)
      • Open any page and make sure you have meta tags in the header 

        <meta name="apple-itunes-app" ...
        		 
        <link rel="manifest" href= ...

      Show
      Policy already covered by behat tests Mobile Enable $CFG->enablemobilewebservice and tool_mobile/enablesmartappbanners ; make sure you have set up tool_mobile/androidappid and tool_mobile/iosappid (you can put anything there, it does not matter) Open any page and make sure you have meta tags in the header <meta name="apple-itunes-app" ... <link rel="manifest" href= ...

      I chose this callback because it has a return value and we do not yet have examples of how to work with them.

      Another thing I want to suggest is to move the legacy call into the hook, I think it will be easier to read the code this way and it will be easier to remove the legacy calls in the future

        1. (1) Passed -- (Main)MDL-79076.png
          57 kB
          Kim Jared Lucas

            marina Marina Glancy
            marina Marina Glancy
            Paul Holden Paul Holden
            Ilya Tregubov Ilya Tregubov
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            17 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 35 minutes
                3h 35m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.