Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Major
Fix Version/s: 4.3.5, 4.4.1
Affects Version/s: 4.3, 4.3.4, 4.4.1
Component/s: Authentication
Labels:

Affected Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE
Fixed Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE
Epic Link:
Add MFA to Moodle LMS - 4.4
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.3 Branch:
~~MDL-78942~~-403
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...paulholden:MDL-78942-403
Pull 4.4 Branch:
~~MDL-78942~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-78942-404
Pull Main Branch:
~~MDL-78942~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-78942
Testing Instructions:
Hide

Copied from ~~MDL-71807~~

Sanity check, just verifying that there isn't any case of codingStandardsIgnore in code.

To do so, just run, in the base/root directory of Moodle:

$ git grep codingStandards

Verify that there is only ONE result, and it belongs to the ./lib/maxmind/MaxMind/Db/Reader/Decoder.php file. That's ok, because it's a third party library and we don't touch them.

Verify that cibot is happy and no coding-style issues are reported with this patch.
Show
Copied from MDL-71807 Sanity check, just verifying that there isn't any case of codingStandardsIgnore in code. To do so, just run, in the base/root directory of Moodle: $ git grep codingStandards Verify that there is only ONE result, and it belongs to the ./lib/maxmind/MaxMind/Db/Reader/Decoder.php file. That's ok, because it's a third party library and we don't touch them. Verify that cibot is happy and no coding-style issues are reported with this patch.

@codingStandardsIgnoreEnd tags are used in the MFA code, They should be review and replace for a better solution.

example admin/tool/mfa/classes/local/form/verification_field.php

This issue is related to this ~~MDL-71807~~

has been marked as being related by

MDL-81606 PR only: MDL-78942 - MFA - Review and replace all @codingStandardsIgnoreXXX tags

Closed

is blocked by

MDL-78509 Add Multi-factor authentication (MFA) plugin

Closed

Assignee:: Paul Holden

Reporter:: Raquel Ortega

Peer reviewer:: David Woloszyn

Integrator:: Andrew Lyons

Tester:: Andrew Lyons

Participants:: Andrew Lyons, CiBoT, David Woloszyn, Jun Pataleta, Paul Holden, Raquel Ortega

Votes:: 0 Vote for this issue

Watchers:: 11 Start watching this issue

Created:: 08/Aug/23 9:30 PM

Updated:: 31/May/24 12:01 AM

Resolved:: 31/May/24 12:01 AM

Estimated:

Remaining:

Logged:

1h 11m

Details

Copied from MDL-71807

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify