Loading...

XML

Word

Printable

Type: Task
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.3
Component/s: Gradebook
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_403_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Main Branch:
~~MDL-78780~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-78780
Testing Instructions:
Hide

Execute the following:

$ git grep -A1 -B2 "get_lang_string[^_]"

Confirm the only matches are the original methods (which emit final deprecation notice) and upgrade notes regarding removal
Show
Execute the following: $ git grep -A1 -B2 "get_lang_string[^_]" Confirm the only matches are the original methods (which emit final deprecation notice) and upgrade notes regarding removal
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-78780~~ using repository: https://github.com/paulholden/moodle.git

main [branch: MDL-78780 | CI Job]

Error: The ~~MDL-78780~~ branch at https://github.com/paulholden/moodle.git is very old (>60 days ago). Please rebase against current main.

Should these errors be fixed?

Built on: Tue Mar 4 07:08:00 UTC 2025
Show
Fails against automated checks. Checked MDL-78780 using repository: https://github.com/paulholden/moodle.git main [branch: MDL-78780 | CI Job ] Error: The MDL-78780 branch at https://github.com/paulholden/moodle.git is very old (>60 days ago). Please rebase against current main. Should these errors be fixed? Built on: Tue Mar 4 07:08:00 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-78780~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18016/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61550/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61551/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61552/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61553/ App tests (stable app version) --> unrelated app failures

Built on: Wed Jan 22 05:58:00 AM UTC 2025
Show
Launching automatic jobs for branch MDL-78780 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18016/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61550/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61551/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61552/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61553/ App tests (stable app version) --> unrelated app failures Built on: Wed Jan 22 05:58:00 AM UTC 2025

In ~~MDL-78561~~ the method grade_helper::get_lang_string() in grade/lib.php was deprecated

In ~~MDL-77033~~ the method grade_report::get_lang_string() in grade/report/lib.php was deprecated

Perform final deprecation of both in 5.0

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-78780_test.png
192 kB
12/Mar/25 4:02 PM

has to be done after

MDL-78561 Deprecate grade_helper:get_lang_string method

Closed

will help resolve

MDL-77307 Final deprecation grader report and grade functions deprecated in Moodle <= 4.2

Closed

Assignee:: Paul Holden

Reporter:: Kevin Percy

Peer reviewer:: Andrew Lyons

Integrator:: Sara Arjona (@sarjona)

Tester:: Sara Arjona (@sarjona)

Participants:: Andrew Lyons, CiBoT, Kevin Percy, Paul Holden, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 21/Jul/23 2:50 PM

Updated:: 11/Apr/25 6:01 PM

Resolved:: 14/Mar/25 11:32 PM

Estimated:

Not Specified

Remaining:

Logged:

3h 29m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify