-
Improvement
-
Resolution: Fixed
-
Minor
-
4.2
-
MOODLE_402_STABLE
-
MOODLE_403_STABLE
-
MDL-78666-master -
Setup
- Apply the patch MDL-78666-test_integration.patch
to your Moodle instance. This will allow us to save activity completion settings without any criteria.
git apply MDL-78666-test.patch - Login as administrator
- Create two users User01 and User02
- Create a course Course01
- Enable completion tracking
- Enrol User01 as a teacher
- Enrol User02 as a student
- Create a database activity Activity01 in Course01
- In Activity completion > Completion tracking select "Show activity as complete when conditions are met" and leave all the checkboxes unchecked
Test teacher
- Login as User01
- Go to Course01 with "Edit mode" enabled
- Click on Activity01 Completion dialog
- Confirm that the dialog shows "You have to add at least one completion condition."
- Confirm that the dialog shows "+ Add conditions" button
- Confirm that the dialog UI follows the prototype
Test student
- Login as User02
- Go to Course01
- Click on Activity01 To do dialog
- Confirm that the dialog shows "There are no completion conditions set for this activity."
- Confirm that the dialog UI follows the prototype
Setup Apply the patch MDL-78666-test_integration.patch to your Moodle instance. This will allow us to save activity completion settings without any criteria. git apply MDL-78666-test.patch Login as administrator Create two users User01 and User02 Create a course Course01 Enable completion tracking Enrol User01 as a teacher Enrol User02 as a student Create a database activity Activity01 in Course01 In Activity completion > Completion tracking select "Show activity as complete when conditions are met" and leave all the checkboxes unchecked Test teacher Login as User01 Go to Course01 with "Edit mode" enabled Click on Activity01 Completion dialog Confirm that the dialog shows "You have to add at least one completion condition." Confirm that the dialog shows "+ Add conditions" button Confirm that the dialog UI follows the prototype Test student Login as User02 Go to Course01 Click on Activity01 To do dialog Confirm that the dialog shows "There are no completion conditions set for this activity." Confirm that the dialog UI follows the prototype - Apply the patch MDL-78666-test_integration.patch
-
1
-
HQ 2023 Planning I3 Moppies
Reviewing MDL-78280 we realized there are some activities (e.g. Database activity) that allow the teacher to set Completion tracking to 'Show activity as complete when conditions are met' but don't mark any of the requirements, so the completion conditions are empty.
This would be probably fixed in MDL-78517.
But even fixing that bug and not allowing teachers to do it never again, some existing activities could face this problem, so we should decide from UX and PX perspective what to show to teachers and students in empty completion criteria use cases.
Designs
Teachers
Students
