Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77603

backport import of Bootstrap v4.6.2

XMLWordPrintable

    • MOODLE_401_STABLE
    • MOODLE_401_STABLE
    • Hide

      Setup

      1. Build SCSS and the component library:

        npx grunt scss componentlibrary
        

      Use 2 Moodle instances, one based on the integration branch including this patch, one on latests 4.1. In both instances take these steps:

      Testing scenario 1: Test if all Boostrap JavaScript works

      1. Login as Admin
      2. Create a course C1
      3. Verify the JS functionality works for: Alerts (dismiss), Buttons (remember state), Carousel (slide), Dropdown (show menu), Popover (show popover). Tooltips (show tooltip)
      4. Access to your apache logs (they use to be placed at /var/log/apache2/error.log) and check that there are no sass parse errors there.

      Testing scenario 2: Check logs

      1. Login as Admin
      2. Navigate to Site Administration -> Development -> Debugging
      3. Choose Developer.. at Debug messages
      4. Tick the Display debug messages checkbox
      5. Open a console showing your web server / PHP log files (they use to be placed at /var/log/apache2/access.log and /var/log/apache2/error.log)
      6. Navigate to Site Administration -> Development -> Purge Caches
      7. Navigate to the Site Homepage
      8. Wait for the page to load and rebuild caches
      9. Check log files (access.log and error.log) doesn't contain errors.

      Component library

      1. Navigate to site admin -> Developerment -> UI Component Library
      2. Browse pages in Moodle and Bootstrap
        1. Confirm that they appear without any unexpected artefacts
      Show
      Setup Build SCSS and the component library: npx grunt scss componentlibrary Use 2 Moodle instances, one based on the integration branch including this patch, one on latests 4.1. In both instances take these steps: Testing scenario 1: Test if all Boostrap JavaScript works Login as Admin Create a course C1 Verify the JS functionality works for: Alerts (dismiss), Buttons (remember state), Carousel (slide), Dropdown (show menu), Popover (show popover). Tooltips (show tooltip) Access to your apache logs (they use to be placed at /var/log/apache2/error.log) and check that there are no sass parse errors there. Testing scenario 2: Check logs Login as Admin Navigate to Site Administration -> Development -> Debugging Choose Developer.. at Debug messages Tick the Display debug messages checkbox Open a console showing your web server / PHP log files (they use to be placed at /var/log/apache2/access.log and /var/log/apache2/error.log) Navigate to Site Administration -> Development -> Purge Caches Navigate to the Site Homepage Wait for the page to load and rebuild caches Check  log files (access.log and error.log) doesn't contain errors. Component library Navigate to site admin -> Developerment -> UI Component Library Browse pages in Moodle and Bootstrap Confirm that they appear without any unexpected artefacts

      Latest Bootstrap toolkit version in Moodle LTS is good, but this would also allow us to start using dart based sass which unlike node-sass is fully supported on all platforms now.

      The risk of regression should be pretty small, the commits were cherry picked from master without any conflicts.

      To reviewers: the CI flagged commit messages from the backported issue MDL-77277, it is correct, this issue number would be included in the merge commit from integration.

            skodak Petr Skoda
            skodak Petr Skoda
            Farhan Karmali Farhan Karmali
            Ilya Tregubov Ilya Tregubov
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 10 minutes
                2h 10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.