Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77510

PHP 8.2: ksort(...) - h5p

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Minor Minor
    • None
    • 4.2
    • H5P
    • 1
    • Team Hedgehog 2023 Sprint 1.4
    • Small

      Based on an Audit of the code, this component has the following uses of ksort without an explicit sort order which means SORT_REGULAR is applied by default and this sort behavior changes in PHP 8.2.
      See: https://php.watch/versions/8.2/ksort-SORT_REGULAR-order-changes

      Instances:

      • ./h5p/tests/editor_framework_test.php:        $this->assertEquals(ksort($expectedlangs), ksort($langs));
      • ./h5p/tests/editor_framework_test.php:        ksort($expectedlibraries);
      • ./h5p/tests/editor_ajax_test.php:        ksort($actuallibraries);
      • ./mod/h5pactivity/classes/output/result.php:        ksort($result);

            raquel.ortega@moodle.com Raquel Ortega
            matt.porritt@moodle.com Matt Porritt
            David Woloszyn David Woloszyn
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 5 minutes
                3h 5m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.