Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77326

Wrong icons are used in Grade summary report

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • MDL-77326-master-1
    • Hide
      1. Create a course with bunch of different activity types
      2. Create some manual grade items
      3. Compare grade summary report with user report
      4. Ensure that relevant grade items have use same icons on those two pages
      5. Ensure you can also see itemtype for each item
      6. Ensure that non manual grade items are links to relevant activities

       

      Show
      Create a course with bunch of different activity types Create some manual grade items Compare grade summary report with user report Ensure that relevant grade items have use same icons on those two pages Ensure you can also see itemtype for each item Ensure that non manual grade items are links to relevant activities  
    • 1
    • Team Alpha - Planning I4-2023

      We are using mixture of icons. Should only use minimized versions for consistency with other report pages.

      Since we already have methods to retrieve minified images and links (used by user report, singlveview and setup page) it make sense to use those methods for summary page too. But those methods (get_element_header(), get_element_icon(), get_element_link(), get_element_type_string()) belong to gtree class which we don't have for summary report page. So I will move those methods to grade_helper class to make them reusable

        1. Screenshot from 2023-02-21 15-12-03.png
          Screenshot from 2023-02-21 15-12-03.png
          14 kB
        2. Screenshot from 2023-10-12 09-14-38.png
          Screenshot from 2023-10-12 09-14-38.png
          103 kB
        3. step_456_2.png
          step_456_2.png
          48 kB
        4. Step_456.png
          Step_456.png
          63 kB
        5. step_456_3.png
          step_456_3.png
          60 kB

            ilyatregubov Ilya Tregubov
            ilyatregubov Ilya Tregubov
            Mihail Geshoski Mihail Geshoski
            Jun Pataleta Jun Pataleta
            Safat Shahin Safat Shahin
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 25 minutes
                4h 25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.