Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.1.1, 4.2, 4.4.8, 4.5.4
Component/s: Libraries
Labels:

Affected Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/DSI-Universite-Rennes2/moodle/
Pull 4.4 Branch:
77137-proxybypass-on-multiple-curl-queries-404
Pull 4.4 Diff URL:
https://github.com/DSI-Universite-Rennes2/moodle/compare/77137-proxybypass-on-multiple-curl-queries-404~1...77137-proxybypass-on-multiple-curl-queries-404
Pull 4.5 Branch:
77137-proxybypass-on-multiple-curl-queries-405
Pull 4.5 Diff URL:
https://github.com/DSI-Universite-Rennes2/moodle/compare/77137-proxybypass-on-multiple-curl-queries-405~1...77137-proxybypass-on-multiple-curl-queries-405
Pull Main Branch:
77137-proxybypass-on-multiple-curl-queries-main
Pull Main Diff URL:
https://github.com/DSI-Universite-Rennes2/moodle/compare/77137-proxybypass-on-multiple-curl-queries-main~1...77137-proxybypass-on-multiple-curl-queries-main
Testing Instructions:
Hide

Testing Instructions :

Go to Site administration > Reports > Security Checks

Then click on Checks all public / private paths

If the 4 tests vendor/, vendor/bin/behat, node_modules/ and node_modules/cli/cli.js are not OK, rename your vendor/ and node_modules/ directories to something else

Once the 4 tests are OK, edit your config.php, and set the following variables at the end of file, just before require_once(__DIR__ . '/lib/setup.php'); :

$CFG->proxyhost = 'i.do.not.exist';

$CFG->proxybypass = parse_url($CFG->wwwroot, PHP_URL_HOST);

Reload the page

You should see that the 4 tests are still OK
Show
Testing Instructions : Go to Site administration > Reports > Security Checks Then click on Checks all public / private paths If the 4 tests vendor/, vendor/bin/behat, node_modules/ and node_modules/cli/cli.js are not OK , rename your vendor/ and node_modules/ directories to something else Once the 4 tests are OK, edit your config.php , and set the following variables at the end of file, just before require_once(__ DIR __ . '/lib/setup.php'); : $CFG ->proxyhost = 'i.do.not.exist' ; $CFG ->proxybypass = parse_url ( $CFG ->wwwroot, PHP_URL_HOST); Reload the page You should see that the 4 tests are still OK
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked MDL-77137 using repository: https://github.com/DSI-Universite-Rennes2/moodle/

MOODLE_404_STABLE (0 errors / 1 warnings) [branch: 77137-proxybypass-on-multiple-curl-queries-404 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The 77137-proxybypass-on-multiple-curl-queries-404 branch at https://github.com/DSI-Universite-Rennes2/moodle/ has not been rebased recently (>20 days ago).

MOODLE_405_STABLE (0 errors / 1 warnings) [branch: 77137-proxybypass-on-multiple-curl-queries-405 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The 77137-proxybypass-on-multiple-curl-queries-405 branch at https://github.com/DSI-Universite-Rennes2/moodle/ has not been rebased recently (>20 days ago).

main (0 errors / 1 warnings) [branch: 77137-proxybypass-on-multiple-curl-queries-main | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The 77137-proxybypass-on-multiple-curl-queries-main branch at https://github.com/DSI-Universite-Rennes2/moodle/ has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Fri May 9 18:13:34 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-77137 using repository: https://github.com/DSI-Universite-Rennes2/moodle/ MOODLE_404_STABLE (0 errors / 1 warnings) [branch: 77137-proxybypass-on-multiple-curl-queries-404 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The 77137-proxybypass-on-multiple-curl-queries-404 branch at https://github.com/DSI-Universite-Rennes2/moodle/ has not been rebased recently (>20 days ago). MOODLE_405_STABLE (0 errors / 1 warnings) [branch: 77137-proxybypass-on-multiple-curl-queries-405 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The 77137-proxybypass-on-multiple-curl-queries-405 branch at https://github.com/DSI-Universite-Rennes2/moodle/ has not been rebased recently (>20 days ago). main (0 errors / 1 warnings) [branch: 77137-proxybypass-on-multiple-curl-queries-main | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The 77137-proxybypass-on-multiple-curl-queries-main branch at https://github.com/DSI-Universite-Rennes2/moodle/ has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Fri May 9 18:13:34 UTC 2025

When HTTP proxy settings are configured, the curl class in filelib.php bypasses proxy settings if needed for a single query, but does not bypass HTTP proxy settings for a multiple queries if needed .

Currently, the bypass setting is never applied to the first query. The next queries apply the parameter that should have been applied to the previous url.

has a non-specific relationship to

MDL-76370 Public / private paths security report is inaccurate when using HTTP proxy

Closed

has been marked as being related by

MDL-38168 Filelib: Curl class does not honour proxybypass option

Closed

Assignee:: Julien Boulen

Reporter:: Julien Boulen

Peer reviewer:: Daniel Ziegenberg

Participants:: CiBoT, Julien Boulen

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 03/Feb/23 10:24 PM

Updated:: 10/May/25 2:13 AM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify