Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76905

Course bulk edit: match the visual style with the prototype

XMLWordPrintable

    • MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • MDL-76905-master
    • Hide

      Some parts of the patch are tested using behat tests. Only a few manual tests are remaining:

      Manual test: minor UI tweaks

      1. Go to "Site administration -> General -> Language -> Language customisation" select English lang pack and click on "open language pack"
      2. Select in "core" the "courseformat" lang file and filter by "bulkselection_plural" string identifier. Set the new value to "{$a} items selected" and save changes to the language pack
      3. Create a course in topics format and set a long course name. For example: "This is a topics format course with a long long long name and some more text to it".
      4. Access the course with editing mode on
        1. Check the "Bulk edit" button near the course title is displayed in a single line ant the text do not wrap.
      5. Click on the "Bulk edit mode"
        1. Check that when you hover the X button on the sticky footer the label is "Close bulk edit"
      6. With no activity or section selected. Tab until you focus on any bulk edit sticky footer element.
        1. Check you cannot focus on the actions buttons (availability, duplicate, move, delete)
      7. Select one activity and then tab until you focus on any bulk edit sticky footer element
        1. Check now the action buttons can be focused using tab (availability, duplicate, move, delete)
        2. Check the sticky footer has a "1 selected" text displayed
      8. Select more activities
        1. Check the sticky footer has a "2 items selected" text displayed
      Show
      Some parts of the patch are tested using behat tests. Only a few manual tests are remaining: Manual test: minor UI tweaks Go to "Site administration -> General -> Language -> Language customisation" select English lang pack and click on "open language pack" Select in "core" the "courseformat" lang file and filter by "bulkselection_plural" string identifier. Set the new value to "{$a} items selected" and save changes to the language pack Create a course in topics format and set a long course name. For example: "This is a topics format course with a long long long name and some more text to it". Access the course with editing mode on Check the "Bulk edit" button near the course title is displayed in a single line ant the text do not wrap. Click on the "Bulk edit mode" Check that when you hover the X button on the sticky footer the label is "Close bulk edit" With no activity or section selected. Tab until you focus on any bulk edit sticky footer element. Check you cannot focus on the actions buttons (availability, duplicate, move, delete) Select one activity and then tab until you focus on any bulk edit sticky footer element Check now the action buttons can be focused using tab (availability, duplicate, move, delete) Check the sticky footer has a "1 selected" text displayed Select more activities Check the sticky footer has a "2 items selected" text displayed
    • 2
    • HQ 2023 Sprint i1.2 Moppies

      Since MDL-76783 was implemented before the final prototype was published some visual elements do not match the current prototype aesthetics.

      However, the UX and workflow implemented in MDL-76783 is consistent with the prototype so this issue is mainly about tweaking the visual elements.

       

      Prototype instructions: https://docs.google.com/document/d/1fDVXPmHkA97TcS4n2Vuus8BB3vBnPlGTnmsInGKdU5I/edit?usp=sharing

      Figma prototype: https://docs.google.com/document/d/1fDVXPmHkA97TcS4n2Vuus8BB3vBnPlGTnmsInGKdU5I/edit?usp=sharing

       

      Some detected differences:

      • With long course names, the bulk editing button line breaks.
      • The bulk button buttons have some cibot complains about the HTML structure.
      • Review strings bulkeditoff and bulkcancel (they look like duplicates)
      • Disabled sticky footer buttons should not be focusable
      • Section availability bulk action title should depend on the format section label (weeks, topics)
      • Even if English does not require a plural string for the selected items count. The string should be different when more than one element is selected.

        1. boost.gif
          boost.gif
          1.09 MB
        2. classic.gif
          classic.gif
          1.25 MB

            tusefomal Ferran Recio
            tusefomal Ferran Recio
            Carlos Escobedo Carlos Escobedo
            Amaia Anabitarte Amaia Anabitarte
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 26 minutes
                1d 26m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.