Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76815

Consistent use of method to determine component of report audience

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.2
    • 4.2
    • Report builder

      Noticed while fixing MDL-76812 - we can improve the code to determine the component of a report audience (that being the plugin/subsystem in which the audience class resides) by removing the duplication we have:

      1. In the audience cards exporter; and
      2. In the audience class helper

      & instead calling the appropriate method of the base class. This method is currently unused, and I think is poorly named/documented as to it's purpose, so we should find a more descriptive name for it at the same time

            pholden Paul Holden
            pholden Paul Holden
            David Carrillo David Carrillo
            Andrew Lyons Andrew Lyons
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 15 minutes
                1h 15m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.