Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76742

Bulk fix php coding style violations across Moodle

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.2
    • Policy
    • None
    • MOODLE_402_STABLE

      As our tooling improves, it might be worth considering applying phpcbf to all files across Moodle (in batches).

      In the long run, this will help us to keep code compliant with our coding style as it becomes easier, and easier, to fix issues discoverd.

      I would suggest that we:

      1. identify any sniffs which should be able to, but currently do not support, the auto-fix feature and add that ability
      2. start with some low-churn targets and apply fixes
      3. build up to higher churn locations

      Once this has been done across the entire codebase, we should look at running phpcbf with our ruleset during GHA, and via TOBIC for all files changes in a patchset.

            Unassigned Unassigned
            dobedobedoh Andrew Lyons
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.