Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76729

File picker not showing thumbnail in tree view

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0.7, 4.1.2
    • 3.11.11, 4.0.5, 4.1
    • Filepicker
    • MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • mdl-76729_401
    • mdl-76729_master
    • Hide

      Test 1

      1. Log in as admin.
      2. Create a course or use an existing one.
      3. Turn edit mode on,
      4. Click on Add an activity or resource and click on File.
      5. In the Select files, click on the Display folder as file tree button.
      6. Add an image to the file manager.
      7. Save and Display.
      8. Edit File settings.
      9. Verify file image preview thumbnail shown (not just a generic icon to represent an image).

      Test 2 (Copied from MDL-71814)

      1. Log in as admin
      2. Add new File activity
      3. Add new files using filepicker
      4. Use 'tab' to choose the "File icons" mode to display the files (one of three buttons in a group on top right)
      5. Tab to a file
      6. Press enter to view the popup with information for the file
      7. Tab and enter to either the close, update or cancel buttons
        • Verify that when the popup closes, the focus returns to the selected file
      8. Repeat the above steps (from step 4) for the other two file display mode buttons "File details" and "File tree" to confirm that it works in all three modes
      Show
      Test 1 Log in as admin. Create a course or use an existing one. Turn edit mode on, Click on Add an activity or resource and click on File. In the Select files, click on the Display folder as file tree button. Add an image to the file manager. Save and Display. Edit File settings. Verify file image preview thumbnail shown (not just a generic icon to represent an image). Test 2 (Copied from MDL-71814 ) Log in as admin Add new File activity Add new files using filepicker Use 'tab' to choose the " File icons " mode to display the files (one of three buttons in a group on top right) Tab to a file Press enter to view the popup with information for the file Tab and enter to either the close, update or cancel buttons Verify that when the popup closes, the focus returns to the selected file Repeat the above steps (from step 4) for the other two file display mode buttons " File details " and " File tree " to confirm that it works in all three modes

      The thumbnail seems to have been disabled in tree view in MDL-71814 Atto: File picker – file info panel focus issue, but it doesn't seem to be necessary to fix the focus issue.

      This is causing an issue for the Multitopic format, preventing preview of the course setting Banner slice.

      Testing Instructions
      1. Log in, enter a course, and turn Edit mode on.
      2. Add a new File activity.
      3. Switch file picker to tree view (folder icon).
      4. Add an image.
      5. Save.
      6. Edit File settings.
      7. Verify file image preview thumbnail shown (not just a generic icon to represent an image).

      To Fix
      In lib/form/filemanager.js in the function view_files, remove the condition:
      if (this.viewmode != 2)

        1. (I) Passed -- (400)MDL-76729.png
          (I) Passed -- (400)MDL-76729.png
          82 kB
        2. (I) Passed -- (401)MDL-76729.png
          (I) Passed -- (401)MDL-76729.png
          68 kB
        3. (I) Passed -- (Master)MDL-76729.png
          (I) Passed -- (Master)MDL-76729.png
          84 kB
        4. BC3.png
          BC3.png
          120 kB
        5. file_in_tree_view.png
          file_in_tree_view.png
          81 kB
        6. file_picker.png
          file_picker.png
          100 kB
        7. multitopic_course_settings.png
          multitopic_course_settings.png
          171 kB

            james-cnz James E. Calder
            james-cnz James E. Calder
            Dan Marsden Dan Marsden
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 24 minutes
                4h 24m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.