-
Bug
-
Resolution: Fixed
-
Minor
-
3.11.11, 4.1, 4.1.5, 4.2.2
-
MOODLE_311_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
-
MOODLE_401_STABLE, MOODLE_402_STABLE
-
MDL-76713-401 -
MDL-76713-master -
Tested using Behat.
Manual tests (for QA if needed):
Test 1:
- Create a course C1
- In C1 create a Label L1
- Edit Restrict Access and add the following:
- Student must match all of the following
- Student must match the following
- Student must match all of the following
- Date until 4 april 2023
- and
- Date until 5 april 2023
- Student must match all of the following
- and
- Date From 4 of April 2023
- and
- Date From 3 april 2023
- and
- Student must match the following
- Student must match all of the following
- Date from 4 april 2023
- and
- Date until 11 april 2023
- Student must match all of the following
- Student must match the following
- Save
- Edit the label again
- Change the second date ( until 5the of April) to from the 6 of april
- Ensure that there is an error message "Conflict with other date restriction" on the first and second date
- Change the fourth date from "Date From 3 april 2023" to "Date Until 3rd of April 2023"
- Ensure that there is an error message "Conflict with other date restriction" on the fourth date
- Student must match all of the following
Test 2:
- Create a course C1
- In C1 create a Label L1
- Edit Restrict Access and add the following:
- Student must match of the following
-
-
- Student must match all of the following
- Date from 4 april 2023
- and
- Date until 5 april 2023
- and
- Student must match all the following
- Date from 6 april 2023
- and
- Date until 7 april 2023
- Student must match all of the following
- Save
- Edit the label again
- Change the second date ( until 5the of April) to until the 3rd of april
- Ensure that there is an error message "Conflict with other date restriction" on the first and second date
- Change the third date to Date from 4 april 2023
- Change the fourth date to Date until 8 april 2023
- Ensure that there is an error message "Conflict with other date restriction" on the fourth date
-
Test 3 (non regression on this particular issue):
- Create a course C1
- In C1 create a Label L1
- Edit Restrict Access and add the following:
- Student must match any of the following
-
-
- Student must match all of the following
- Date from 4 april 2023
- and
- Date until 5 april 2023
- and
- Student must match all the following
- Date from 6 april 2023
- and
- Date until 7 april 2023
- Student must match all of the following
- Ensure that there is no related "Conflict with other date restriction" on the first and second date
-
This is the screenshot how the issue before the patch with the same configuration. Note that the errors will not appear if the configuration was somewhat saved before successfully (switching between code branches).
Tested using Behat. Manual tests (for QA if needed): Test 1: Create a course C1 In C1 create a Label L1 Edit Restrict Access and add the following: Student must match all of the following Student must match the following Student must match all of the following Date until 4 april 2023 and Date until 5 april 2023 and Date From 4 of April 2023 and Date From 3 april 2023 and Student must match the following Student must match all of the following Date from 4 april 2023 and Date until 11 april 2023 Save Edit the label again Change the second date ( until 5the of April) to from the 6 of april Ensure that there is an error message "Conflict with other date restriction" on the first and second date Change the fourth date from "Date From 3 april 2023" to "Date Until 3rd of April 2023" Ensure that there is an error message "Conflict with other date restriction" on the fourth date Test 2: Create a course C1 In C1 create a Label L1 Edit Restrict Access and add the following: Student must match of the following Student must match all of the following Date from 4 april 2023 and Date until 5 april 2023 and Student must match all the following Date from 6 april 2023 and Date until 7 april 2023 Save Edit the label again Change the second date ( until 5the of April) to until the 3rd of april Ensure that there is an error message "Conflict with other date restriction" on the first and second date Change the third date to Date from 4 april 2023 Change the fourth date to Date until 8 april 2023 Ensure that there is an error message "Conflict with other date restriction" on the fourth date Test 3 (non regression on this particular issue): Create a course C1 In C1 create a Label L1 Edit Restrict Access and add the following: Student must match any of the following Student must match all of the following Date from 4 april 2023 and Date until 5 april 2023 and Student must match all the following Date from 6 april 2023 and Date until 7 april 2023 Ensure that there is no related "Conflict with other date restriction" on the first and second date This is the screenshot how the issue before the patch with the same configuration. Note that the errors will not appear if the configuration was somewhat saved before successfully (switching between code branches).
-
3
-
HQ 2023 Planning i2 Moppies
Hello,
we have detected a possible bug in the activity module date restrictions settings. When setting two sets of valid date restrictions, a warning is displayed stating "Conflicts with other date restrictions". The conflict doesn't seem to be there.
We have tested this in both Moodle 3.11.11 and 4.1. It can be replicated by following the steps below:
- Create an empty course.
- Create an activity (quiz, for example) and set date restrictions as follows:
- Add a restriction set.
- Within the previous set, add two new separate sets.
- Within the last two sets, add, in each set, two date restrictions and configure them as shown in the screenshots (group restriction are optional).
- Add a grade restriction on the first level as show in the screenshots.
- This is not really necessary to reproduce the problem, it is just to make sense of the first level of conditions, otherwise it might seem redundant. This is the way, in the actual use case, we have detected the error.
Expected: should not show the date conflict warning.
What happens: shows date conflict between two dates that should be independent.
I have created a post in the moodle forum about this: https://moodle.org/mod/forum/discuss.php?d=441498
It could be related to this issue: https://tracker.moodle.org/browse/MDL-72490
Regards
