-
Bug
-
Resolution: Fixed
-
Minor
-
4.0.5, 4.0.6, 4.1, 4.1.1
-
MOODLE_400_STABLE, MOODLE_401_STABLE
-
MOODLE_400_STABLE, MOODLE_401_STABLE
-
MDL-76584-401 -
These tests are based on those in the original issue (
MDL-73808) but create fewer questionsMigrating from 3.11 (basic test as it changes the migration code and performance test)
- Standup a new 3.11 site
- Log in as an admin
- Create a course and 50 questions with tags using the test_73808_solo_light.php
script - Confirm:
- That the new course and quiz is created by the script and questions are available in the course context
- Add some random questions using the same question category and add some tags for each one of them
- Add some regular questions from the question bank
- Logout and login as a student
- Attempt the quiz
- Logout from the account
- Change the code using this tracker
- Upgrade the site
- Log in as a site admin
- Confirm:
- That the created questions are available in the question bank
- That the created questions have only one version and the version is 1
- That the added random questions are available in the quiz
- That the attempts are available in the quiz
- The added tags for the random questions are available in the quiz
- Logout and login as a student
- Attempt the quiz
- Confirm:
- The quiz attempt works as expected and all the questions are available.
- Confirm:
- That the upgrade happens as expected without timeout or asking for extra memory.
These tests are based on those in the original issue ( MDL-73808 ) but create fewer questions Migrating from 3.11 (basic test as it changes the migration code and performance test) Standup a new 3.11 site Log in as an admin Create a course and 50 questions with tags using the test_73808_solo_light.php script Confirm: That the new course and quiz is created by the script and questions are available in the course context Add some random questions using the same question category and add some tags for each one of them Add some regular questions from the question bank Logout and login as a student Attempt the quiz Logout from the account Change the code using this tracker Upgrade the site Log in as a site admin Confirm: That the created questions are available in the question bank That the created questions have only one version and the version is 1 That the added random questions are available in the quiz That the attempts are available in the quiz The added tags for the random questions are available in the quiz Logout and login as a student Attempt the quiz Confirm: The quiz attempt works as expected and all the questions are available. Confirm: That the upgrade happens as expected without timeout or asking for extra memory.
During upgrade to 4.0 or later column questionid is temporarily added to mdl_question_bank_entries. The column's definition in lib/db/upgrade.php (in if ($oldversion < 2022020200.02){} ) is:
$field = new xmldb_field('questionid', XMLDB_TYPE_INTEGER, '10', null, XMLDB_TYPE_INTEGER);
|
That last parameter should be either XMLDB_NOTNULL or null (or not included), but not XMLDB_TYPE_INTEGER.
Issue exists both with the create and the drop 47 lines later.
