Loading...

XML

Word

Printable

Type: Task
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.2, 4.3, 4.4, 5.0
Component/s: Automated functional tests (behat)
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Main Branch:
~~MDL-76564~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-76564
Testing Instructions:
Hide

Execute the following:

$ grep -lr "extends.*behat_deprecated_base" . | xargs grep -n @deprecated

Confirm there are no deprecated steps from 4.4 or earlier

Automated tests will cover the rest
Show
Execute the following: $ grep -lr "extends.*behat_deprecated_base" . | xargs grep -n @deprecated Confirm there are no deprecated steps from 4.4 or earlier Automated tests will cover the rest
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-76564~~ using repository: https://github.com/paulholden/moodle.git

main (0 errors / 1 warnings) [branch: MDL-76564 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-76564~~ branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Wed 30 Oct 2024 01:56:14 PM UTC
Show
Code verified against automated checks with warnings. Checked MDL-76564 using repository: https://github.com/paulholden/moodle.git main (0 errors / 1 warnings) [branch: MDL-76564 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-76564 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Wed 30 Oct 2024 01:56:14 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-76564~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17192/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58519/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58520/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58521/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58522/ App tests (stable app version) --> unrelated, reported to apps team.

Built on: Wed Oct 30 04:30:15 PM UTC 2024
Show
Launching automatic jobs for branch MDL-76564 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17192/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58519/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58520/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58521/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58522/ App tests (stable app version) --> unrelated, reported to apps team. Built on: Wed Oct 30 04:30:15 PM UTC 2024

Go through lib/tests/behat/behat_deprecated.php and other component/plugin test directories (see ~~MDL-73669~~) and remove steps that were deprecated in Moodle 4.4 or earlier. Specifically:

4.4
4.3
4.2
Other earlier versions

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 2 Passed -- (Main)MDL-76564.png
31/Oct/24 10:15 AM
34 kB
Kim Jared Lucas

has a clone

MDL-78077 Remove Behat steps deprecated in Moodle versions <= 5.2

Open

is a clone of

MDL-74581 Remove behat steps deprecated in 4.1

Closed

will help resolve

MDL-77107 Remove grades and grade report Behat steps deprecated in 4.2

Closed

Assignee:: Paul Holden

Reporter:: Jun Pataleta

Peer reviewer:: Angelia Dela Cruz

Integrator:: Simey Lameze

Tester:: Kim Jared Lucas

Participants:: Angelia Dela Cruz, CiBoT, Daniel Ziegenberg, Jun Pataleta, Kim Jared Lucas, Paul Holden, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 05/Dec/22 1:40 PM

Updated:: 11/Apr/25 6:02 PM

Resolved:: 01/Nov/24 4:24 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 7m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify