Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76224

Wrong page url set in mod_label view.php

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.11.11, 4.0.5
    • 3.11.10, 4.0.4
    • Resource
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MDL-76224-master
    • Hide
      Setup
      1. Navigate to a Course
      2. Create a Label ("Text and media") activity and return to the course
      3. Click on 'Edit settings' in the dropdown menu for the label
      4. Find the id of the label by looking at your current url. The url will be <wwwroot>/course/modedit.php?update=<id>&return=..., so note the integer following update=
      Testing instructions
      1. Open an incognito window of your browser
      2. Go to <wwwroot>/mod/label/view.php?id=<id> , replacing id with your noted integer
      3. Login with your credentials
      4. Verify that you are now in the course containing the label
      Show
      Setup Navigate to a Course Create a Label (" Text and media ") activity and return to the course Click on 'Edit settings' in the dropdown menu for the label Find the id of the label by looking at your current url. The url will be <wwwroot>/course/modedit.php?update= <id> &return=..., so note the integer following update= Testing instructions Open an incognito window of your browser Go to <wwwroot>/mod/label/view.php?id= <id> , replacing id with your noted integer Login with your credentials Verify that you are now in the course containing the label

      The mod/label/view.php mistakenly sets its URL as mod/label/index.php with a wrong parameter (cmid is given, but courseid is expected).

      This leads to a redirect to a nonexisting course by require_login() when accessing the view.php before logging in (happens in the case of changed course content mails).

        1. MDL-76224_master.webm
          570 kB
        2. MDL-76224_v311.webm
          665 kB
        3. MDL-76224_v400.webm
          544 kB

            justusdieckmann Justus Dieckmann
            justusdieckmann Justus Dieckmann
            Stephan Robotta Stephan Robotta
            Paul Holden Paul Holden
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            15 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 10 minutes
                1h 10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.