Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76123

Activity icon has invalid multi-language 'alt' text

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.1.5, 4.2.2
    • 4.0.4, 4.1, 4.1.4
    • Course
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-76123-401
    • Hide
      1. Log in as admin
      2. Create a course
      3. Inspect browser DOM
      4. Confirm presence of alt="Forum icon" attribute of the Announcements forum icon
      5. Master
        • Hover over the forum icon, confirm there is no tooltip
      6. 402, 401
        • Confirm there is no FORUM text above the forum activity name
      7. Turn editing on
      8. Confirm alt attribute is still present in the Announcements forum icon
      9. Master
        • Hover over the forum icon, confirm there is a "Forum" tooltip
      10. 402, 401
        • Confirm there is FORUM text above the forum activity name
      Show
      Log in as admin Create a course Inspect browser DOM Confirm presence of alt="Forum icon" attribute of the Announcements forum icon Master Hover over the forum icon, confirm there is no tooltip 402, 401 Confirm there is no FORUM text above the forum activity name Turn editing on Confirm alt attribute is still present in the Announcements forum icon Master Hover over the forum icon, confirm there is a "Forum" tooltip 402, 401 Confirm there is FORUM text above the forum activity name

      In the file '/course/format/templates/local/content/cm/cmname.mustache' there this the markup:

      <img src="{{{icon}}}" class="activityicon " alt="{{modname}} icon">

      The 'alt' attribute is used to provide a human language alternative description of the image, and yet here there are hard coded English words used, so 'icon' and the templated module name, which will also be English, such as 'forum'.  For example, 'icon' in Welsh is 'eicon'.  Therefore this needs fixing to something like:

      <img src="{{{icon}}}" class="activityicon" alt="{{pluginname}}">

      where the templated 'pluginname' will change as the language changes.

      Note: Tracker text editor may have messed with the curly brackets.

        1. MDL-76123.png
          870 kB
          Ron Carl Alfon Yu

            pholden Paul Holden
            gb2048 Gareth J Barnard
            Mikel Martín Corrales Mikel Martín Corrales
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            4 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 41 minutes
                1h 41m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.