Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76080

mod_data: Test for create_field does not test anything

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 4.1
    • None

      Discovered while running tests on PHP8.1 :

      PHP Deprecated:  strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /var/www/html/mod/data/tests/generator_test.php on line 120
      

      \mod_data\generator_test::test_create_field() does not really test 'addtemplate' field because all records in the table 'data' in this test have addtemplate == NULL

      I'm not sure if it can be replaced with a more meaningful test or just removed

            marina Marina Glancy
            marina Marina Glancy
            Paul Holden Paul Holden
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 15 minutes
                1h 15m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.