-
Bug
-
Resolution: Fixed
-
Minor
-
4.1
-
2
-
Team Hedgehog Sprint 1 review
The $num_points parameter of image(open|filled)polygon has been deprecated.
And we have a few of them in core:
$ ag 'image.*polygon' --php
|
lib/graphlib.php
|
1568: ImageFilledPolygon($this->image, array($u, $v-$half, $u+$half, $v, $u, $v+$half, $u-$half, $v), 4, $this->colour[$colour]);
|
1571: ImagePolygon($this->image, array($u, $v-$half, $u+$half, $v, $u, $v+$half, $u-$half, $v), 4, $this->colour[$colour]);
|
1574: ImageFilledPolygon($this->image, array($u, $v-$half, $u+$half, $v+$half, $u-$half, $v+$half), 3, $this->colour[$colour]);
|
1577: ImagePolygon($this->image, array($u, $v-$half, $u+$half, $v+$half, $u-$half, $v+$half), 3, $this->colour[$colour]);
|
1668: ImageFilledPolygon($this->image, array($u_start, $v_start, $u_end, $v_end, $u_end, $zero, $u_start, $zero), 4, $this->colour[$colour]);
|
1669: ImagePolygon($this->image, array($u_start, $v_start, $u_end, $v_end, $u_end, $zero, $u_start, $zero), 4, $this->colour[$colour]);
|
1672: //ImagePolygon($this->image, array($u_start, $v_start, $u_end, $v_end, $u_end, $zero, $u_start, $zero), 4, $this->colour[$colour]);
|
1689: ImageFilledPolygon($this->image, array($u_start, $v_start, $u_end, $v_end, $u_end, $bottom, $u_start, $bottom), 4, $this->colour[$colour]);
|
1692: ImagePolygon($this->image, array($u_start, $v_start, $u_end, $v_end, $u_end, $bottom, $u_start, $bottom), 4, $this->colour[$colour]);
|
1779: ImageFilledPolygon($this->image, array($x+$half, $y-$half,
|
1786: ImageFilledPolygon($this->image, array($x-$half, $y-$half,
|
Note that, surely, in order to keep both 8.1 and older php versions working without notices... we'll need to make some conditional coding here, using PHP_VERSION_ID >= 80100 or version_compare(PHP_VERSION, '8.1', '>='.
Ciao 
