Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75532

LTI Advantage grade sync task still assumes lineitems URL is a required service data field

XMLWordPrintable

    • 1
    • Team Hedgehog Sprint 1.3
    • Small

      This was missed in MDL-74691 and needs a fix here. See this code:
      https://github.com/moodle/moodle/blob/d5ed4a3184e8187edad0eae9cb290c4f5cea1a6b/enrol/lti/classes/local/ltiadvantage/task/sync_grades.php#L162

      E.g.

      $lineitemurl = $gradeservice->get_lineitemurl();        
              
      $servicedata = [
                     
          'lineitems' => $gradeservice->get_lineitemsurl()->out(false),
              
          'lineitem' => $lineitemurl ? $lineitemurl->out(false) : null,
              
          'scope' => $gradeservice->get_scopes(),
              
      ]; 

      This needs to handle lineitems the same way as it does lineitem. I.e. with an existence check before calling out() on it.

            jaked Jake Dallimore
            jaked Jake Dallimore
            Safat Shahin Safat Shahin
            Paul Holden Paul Holden
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 26 minutes
                2h 26m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.