Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75236

mod/data/amd/src/templateseditor.js generate a console warning when editing csstemplate or jstemplate.

XMLWordPrintable

    • MOODLE_401_STABLE
    • Hide
      1. In a course C1, create a database activity D1
      2. Use a predefined preset so to add fields (the image gallery preset is fine)
      3. Go to the template editor
      4. Open the development console on the browser
      5. Select a template (not the CSS or JS template): there should be no error in the console log of the browser
      6. Select the JS template and the CSS template: there should be no error in the console log of the browser

       

      Show
      In a course C1, create a database activity D1 Use a predefined preset so to add fields (the image gallery preset is fine) Go to the template editor Open the development console on the browser Select a template (not the CSS or JS template): there should be no error in the console log of the browser Select the JS template and the CSS template: there should be no error in the console log of the browser  
    • 1
    • HQ Sprint 0.2 Database

      The mod_data template editor generate a js warning when the user selects the js template or the CSS one. This is happening because the toggle template editor is not present in those templates and the AMD module does not check it.

      The solution is quite simple as it only requires checking for toogleTemaplteEditor value at the registerEventListeners function. This bug is been detected and fixed in MDL-75146 but only in Moodle 4.1 because it was necessary for some new behat tests to work.

      In this issue the same fix should be applied to all active versions.

            laurent.david@moodle.com Laurent David
            tusefomal Ferran Recio
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 54 minutes
                1h 54m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.