Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74714

Clarify optional exporter properties for custom reports

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.1
    • 4.1
    • Report builder

      The custom report exporter defines all data from additional exporters as non-optional: https://github.com/moodle/moodle/blob/941a29925e5cd1c1dddefa08cede7950593080b0/reportbuilder/classes/external/custom_report_exporter.php#L92-L96

      This means all additional exporters are defining each of their own properties as optional: https://github.com/moodle/moodle/blob/941a29925e5cd1c1dddefa08cede7950593080b0/reportbuilder/classes/external/custom_report_filters_exporter.php#L54-L96 - despite always populating them

      The properties on the main custom report exporter should be optional (to define whether they exist at all), the properties on the additional exporters should only be optional when necessary

      Noticed while writing unit tests in MDL-74694. Moved to this issue as probably master only change, as will slightly amend the return structure of various external methods that use the read definition of exporters

            pholden Paul Holden
            pholden Paul Holden
            David Carrillo David Carrillo
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 55 minutes
                1h 55m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.