Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74634

Remove 'drawer-open-nav' user preference, unused since MDL-73548

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.1
    • 4.1
    • Themes
    • MOODLE_401_STABLE
    • MOODLE_401_STABLE
    • Hide
      Setup
      1. Install a Moodle 3.11 instance
      2. Log in as admin
      3. Close then open the navigation drawer
      4. Log in as another user and close the navigation drawer
      5. Check the user preferences table on your favourite database management tool to check for the presence of "drawer-open-nav" records. e.g. 

        SELECT * FROM mdl_user_preferences WHERE name = 'drawer-open-nav'

      6. Check out Moodle 4.0 and upgrade to it 

        git checkout v4.0.0

      7. Upgrade your site. Check again for the drawer-open-nav records. They should still be there.
      Test
      1. Check out the branch with the patch applied.
      2. Re-run the SELECT ... query from above
      3. Confirm it doesn't return any matching records
      4. Unit tests cover the rest of the changes
      Show
      Setup Install a Moodle 3.11 instance Log in as admin Close then open the navigation drawer Log in as another user and close the navigation drawer Check the user preferences table on your favourite database management tool to check for the presence of " drawer-open-nav " records. e.g. SELECT * FROM mdl_user_preferences WHERE name = 'drawer-open-nav' Check out Moodle 4.0 and upgrade to it git checkout v4.0.0 Upgrade your site. Check again for the drawer-open-nav records. They should still be there. Test Check out the branch with the patch applied. Re-run the SELECT ... query from above Confirm it doesn't return any matching records Unit tests cover the rest of the changes

      As commented by stronk7 in the original task, here:

      I'd strongly (well, not so strongly, but I would, heh) recommend to create an issue about the removal of the old user preference (from DB, from code and from lang strings...) if it has not been removed yet.

        1. MDL-74634_Test Passed.png
          65 kB
          Gladys Basiana

            pholden Paul Holden
            pholden Paul Holden
            Sujith Haridasan Sujith Haridasan
            Jun Pataleta Jun Pataleta
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 5 minutes
                3h 5m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.