Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74569

Undo top: 0vh; in theme/boost/scss/moodle/grade.scss

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0.5
    • 4.0, 4.0.1
    • Themes
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-74569-master
    • Hide

      Before applying the patch

      1. Do run grunt css.
      2. Confirm you get the following message in the "stylelint:scss" task:

        >> theme/boost/scss/moodle/grade.scss
        >> 455:19 ⚠ Unexpected unit length-zero-no-unit

      After applying the patch

      1. Do run grunt css.
      2. Verify no error is given out reminding you that 0 values should have no unit.

      Verifying the testing instructions of MDL-74297 still do apply

      Setup

      1. Restore the attached course
      2. Confirm there are at least 20 students enrolled
      3. On the course page, add enough blocks to trigger a scroll in the blocks drawer

      Testing

      1. Log in as an admin
      2. Go to the course page
      3. Confirm the start of the scrollable content is the content of the page without the primary navigation
        1. The scrollbar should start below the primary navigation
      4. Reduce the browser width to half
      5. Open the blocks drawer(it should open in a floating drawer due to reduce width)
      6. Confirm the scroll on the page has disappeared.
      7. Confirm you can scroll within the drawer.
      8. Close the drawer
      9. Confirm the page scroll is visible again
      10. Click on the Grades tab
      11. Confirm the 'Overall average' bar is displayed at the bottom
      12. Scroll down the page
      13. Confirm the header becomes sticky at the top of the page below the primary navigation

      Classic

      1. Log in as admin
      2. Go to the course grades page
      3. Repeat #11-#13

      Repeat test on available browsers - Chrome, FF etc and in Mobile Views

      Show
      Before applying the patch Do run grunt css . Confirm you get the following message in the "stylelint:scss" task: >> theme/boost/scss/moodle/grade.scss >> 455:19 ⚠ Unexpected unit length-zero-no-unit After applying the patch Do run grunt css . Verify no error is given out reminding you that 0 values should have no unit. Verifying the testing instructions of MDL-74297 still do apply Setup Restore the attached course Confirm there are at least 20 students enrolled On the course page, add enough blocks to trigger a scroll in the blocks drawer Testing Log in as an admin Go to the course page Confirm the start of the scrollable content is the content of the page without the primary navigation The scrollbar should start below the primary navigation Reduce the browser width to half Open the blocks drawer(it should open in a floating drawer due to reduce width) Confirm the scroll on the page has disappeared. Confirm you can scroll within the drawer. Close the drawer Confirm the page scroll is visible again Click on the Grades tab Confirm the 'Overall average' bar is displayed at the bottom Scroll down the page Confirm the header becomes sticky at the top of the page below the primary navigation Classic Log in as admin Go to the course grades page Repeat #11-#13 Repeat test on available browsers - Chrome, FF etc and in Mobile Views

      In theme/boost/scss/moodle/grade.scss, top: 0vh; is invalid.
      0 should not have any unit.

        1. backup-moodle2-course-47-mdk101-28084-20220407-0833.mbz
          7.62 MB
          Luca Bösch
        2. MDL-74569_after patch.png
          33 kB
          Angelia Dela Cruz
        3. MDL-74569_before patch.png
          42 kB
          Angelia Dela Cruz
        4. MDL-74569_boost_chrome.mp4
          4.77 MB
          Angelia Dela Cruz
        5. MDL-74569_boost_edge.mp4
          5.14 MB
          Angelia Dela Cruz
        6. MDL-74569_boost_firefox.mp4
          5.85 MB
          Angelia Dela Cruz
        7. MDL-74569_boost_mobile.mp4
          5.66 MB
          Angelia Dela Cruz
        8. MDL-74569_boost_opera.mp4
          4.75 MB
          Angelia Dela Cruz
        9. MDL-74569_boost_safari.mp4
          5.31 MB
          Angelia Dela Cruz
        10. MDL-74569_classic_chrome.mp4
          3.29 MB
          Angelia Dela Cruz
        11. MDL-74569_classic_edge.mp4
          3.15 MB
          Angelia Dela Cruz
        12. MDL-74569_classic_firefox.mp4
          3.54 MB
          Angelia Dela Cruz
        13. MDL-74569_classic_mobile.mp4
          4.43 MB
          Angelia Dela Cruz
        14. MDL-74569_classic_opera.mp4
          4.33 MB
          Angelia Dela Cruz
        15. MDL-74569_classic_safari.mp4
          4.39 MB
          Angelia Dela Cruz

            lucaboesch Luca Bösch
            lucaboesch Luca Bösch
            Huong Nguyen Huong Nguyen
            Victor Déniz Falcón Victor Déniz Falcón
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours, 7 minutes
                6h 7m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.