Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74499

Regression: Plugin icons are overwritten by new monologo

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 4.0
    • Themes
    • None
    • MOODLE_400_STABLE

      The "resolve_image_location" replaces all icons with the new monologo icon.

       

      eg:
      pix_icon('qrcode', '', 'attendance')
      will get overwritten with monologo icon.
       
      "qrcode" is set here:
      https://github.com/moodle/moodle/blob/master/lib/outputlib.php#L2112

      but then if the plugin comes from a mod-  the candidates array is completely reset here, removing the correct icon name "qrcode"

      https://github.com/moodle/moodle/blob/master/lib/outputlib.php#L2123
       
      that like should sit within the " if ($image === 'icon')" statement.
       
      it was in that location in earlier patches - not sure why it was shifted outside it?

            Unassigned Unassigned
            danmarsden Dan Marsden
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.