Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74169

Notification preferences link displayed even when editing is not allowed

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.11.7
    • 3.11.5, 3.11.6, 4.0
    • Messages
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE
    • MDL-74169-master
    • Hide

      1. Login as admin
      2. Confirm that the "Cog" leading to the notification preferences is visible in the notifications drawer
      3. Confirm that the "Cog" leading to the notification preferences is visible in the messages drawer
      4. Disable the capability moodle/user:editownmessageprofile for the "Authenticated user" role
      5. Login as a non-admin user
      6. Confirm that the "Cog" leading to the notification preferences is NOT visible in the notifications drawer
      7. Confirm that the "Cog" leading to the notification preferences is NOT visible in the messages drawer

      Show
      1. Login as admin 2. Confirm that the "Cog" leading to the notification preferences is visible in the notifications drawer 3. Confirm that the "Cog" leading to the notification preferences is visible in the messages drawer 4. Disable the capability moodle/user:editownmessageprofile for the "Authenticated user" role 5. Login as a non-admin user 6. Confirm that the "Cog" leading to the notification preferences is NOT visible in the notifications drawer 7. Confirm that the "Cog" leading to the notification preferences is NOT visible in the messages drawer

      Users who do not have the capability to moodle/user:editownmessageprofile should not be shown a link to go and and edit their notification preferences.

      Replication steps

      1. Disable the capability moodle/user:editownmessageprofile for the "Authenticated user" role
      2. Login as a non-admin user
      3. Open the notification drawer

      Expected

      The link to the preferences (cog icon) is not displayed.

      Actual

      The link to the preferences (cog icon) is displayed.

      –

      This probably affects other views, I only investigated the notifications one. This was discovered on 4.0-beta but seems to occur on 3.11.5. Patch will be provided.

        1. MDL-74169_master.webm
          2.03 MB
        2. MDL-74169_v311.webm
          2.24 MB
        3. Screenshot from 2022-03-21 10-41-14.png
          Screenshot from 2022-03-21 10-41-14.png
          8 kB

            fred Frédéric Massart
            fred Frédéric Massart
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Ilya Tregubov Ilya Tregubov
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 1 minute
                1h 1m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.