Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73950

Fix icon spacing in dynamic registration URL actions boxes

XMLWordPrintable

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-73950-master
    • Hide
      1. Go to Site admin > Plugins > Enrolments > Manage enrolment plugins
      2. Enable Publish as LTI Tool
      3. Now, go to Site admin > Plugins > Enrolments > Publish as LTI tool > Tool registration
      4. Generate a new dynamic registration URL
      5. Verify the icons (copy, delete) next to the URL are evenly spaced. I.e. they appear in the middle of their respective container and look like the screenshot here:
      Show
      Go to Site admin > Plugins > Enrolments > Manage enrolment plugins Enable Publish as LTI Tool Now, go to Site admin > Plugins > Enrolments > Publish as LTI tool > Tool registration Generate a new dynamic registration URL Verify the icons (copy, delete) next to the URL are evenly spaced. I.e. they appear in the middle of their respective container and look like the screenshot here:
    • 1
    • Navigation push 14

      Noticed this while I was documenting the feature. This was fixed during a prior iteration of the enrol/lti code, but I removed it since at the time I thought it wasn't having any effect. In fact it was, and I was silly to remove it.

      enrol/lti/styles.css needs the following:

      #registration-tab-content .input-group-append a.btn span.pix {
          padding-left: 0.5rem;
      } 

      to ensure the spacing on either side of the pix icon is even.

      Without the fix:

      With the fix:

        1. fixed_icon_spacing.png
          21 kB
          Jake Dallimore
        2. MDL-73950 testing.png
          113 kB
          Angelia Dela Cruz
        3. uneven_icon_spacing.png
          21 kB
          Jake Dallimore

            jaked Jake Dallimore
            jaked Jake Dallimore
            Peter Dias Peter Dias
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.