Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73837

Column attributes are not used in system reports

XMLWordPrintable

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Hide

      Setup

      1. Apply the MDL-73837.diff patch to your site

      Custom reports

      1. Log in as admin
      2. Navigate to Reports > Report builder > Custom reports in site administration
      3. Create a new report using the Users report source
        • Ensure Include default setup is unchecked
      4. In the editor add the following columns:
        • User > Full name
        • User > Country
      5. Inspect the table DOM, confirm that the <td> elements in the Full name column have the following attributes:

        data-this-column="awesome"
        

      6. Confirm the <td> elements in the Country column do not
      7. Press Preview
      8. Repeat steps 5. & 6.

      System reports

      1. Close the editor to return to list of reports
      2. Inspect the table DOM, confirm that the <td> elements in the Modified by column have the following attributes:

        data-this-column="awesome"
        

      3. Confirm the <td> elements in the other columns do not
      Show
      Setup Apply the MDL-73837.diff patch to your site Custom reports Log in as admin Navigate to Reports > Report builder > Custom reports in site administration Create a new report using the Users report source Ensure Include default setup is unchecked In the editor add the following columns: User > Full name User > Country Inspect the table DOM, confirm that the <td> elements in the Full name column have the following attributes: data-this-column="awesome" Confirm the <td> elements in the Country column do not Press Preview Repeat steps 5. & 6. System reports Close the editor to return to list of reports Inspect the table DOM, confirm that the <td> elements in the Modified by column have the following attributes: data-this-column="awesome" Confirm the <td> elements in the other columns do not

      If a column has any attributes set for it (via ->add_attributes([...]) method), they are only included in report output for custom reports, they are entirely absent when the column is used in a system report

      We should use the same API that mikelmartíncorrales added to support the same in custom reports in MDL-72565 (specifically this change)

        1. Custom reports_Screenshot.png
          196 kB
          Gladys Basiana
        2. MDL-73837.diff
          0.6 kB
          Paul Holden
        3. System reports_Screenshot.PNG
          54 kB
          Gladys Basiana

            pholden Paul Holden
            pholden Paul Holden
            Ruslan Kabalin Ruslan Kabalin
            Ilya Tregubov Ilya Tregubov
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 55 minutes
                1h 55m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.