-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
3.9.12, 3.10.9, 3.11.5, 4.0, 4.1
-
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
-
MDL-73798-bounce-counts-MOODLE_404_STABLE
-
MDL-73798-bounce-counts-MOODLE_405_STABLE
-
MDL-73798-bounce-counts
-
-
Fails against automated checks. 
Checked MDL-73798 using repository: https://github.com/bwalkerl/moodle
MOODLE_404_STABLE (1 errors / 2 warnings) [branch: MDL-73798-bounce-counts-MOODLE_404_STABLE | CI Job]
- MOODLE_405_STABLE (1 errors / 2 warnings) [branch: MDL-73798-bounce-counts-MOODLE_405_STABLE | CI Job]
- main (1 errors / 2 warnings) [branch: MDL-73798-bounce-counts | CI Job]
Built on: Thu 05 Dec 2024 12:03:25 AM UTC
Fails against automated checks. Checked MDL-73798 using repository: https://github.com/bwalkerl/moodle MOODLE_404_STABLE (1 errors / 2 warnings) [branch: MDL-73798-bounce-counts-MOODLE_404_STABLE | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/2) , js (0/0) , css (0/0) , phpdoc (1/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_405_STABLE (1 errors / 2 warnings) [branch: MDL-73798-bounce-counts-MOODLE_405_STABLE | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/2) , js (0/0) , css (0/0) , phpdoc (1/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (1 errors / 2 warnings) [branch: MDL-73798-bounce-counts | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/2) , js (0/0) , css (0/0) , phpdoc (1/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Thu 05 Dec 2024 12:03:25 AM UTC
The email bounce quota handling is essentially broken for all Moodle instances that don't employ manual user profile creation/updating.
Note: Duplicate of MDL-16891, to mark the source commit's 17th birthday tomorrow. 🥳
Commit bb64b51aa335 introduced user-specific handling of email bounces.
However, the two base values that are necessary for bounce quota calculations (email_send_count and email_bounce_count) are only gathered when a user account's email address has been modified manually at least once before.
Technical details:
Both set_send_count() and set_bounce_count() only operate on existing values in mdl_user_preferences (=probably unintended/faulty behavior). But creation of these values only occurs when they get reset - which happens in useredit_update_bounces() right now. This function however is only called in user/edit(advanced).php, which is probably another bug: it means that the address-specific bounce counters won't get reset when changing an email address via external data source (auth plugin login or sync).