-
Bug
-
Resolution: Fixed
-
Minor
-
4.0
-
MOODLE_400_STABLE
-
MOODLE_400_STABLE
-
MDL-73766-master -
- Test in Boost
- As Admin, set the full site name to "Moodle 4.0", be sure to not set a large logo.
- Log out.
- When logging in verify the header says "Log in to Moodle 4.0".
- Log in.
- Set a large logo.
- Log out.
- Try to log in again.
- When logging in, in the source, verify the sr-only element for the image header says "Log in to Moodle 4.0".
Test in Boost As Admin, set the full site name to "Moodle 4.0", be sure to not set a large logo. Log out. When logging in verify the header says "Log in to Moodle 4.0". Log in. Set a large logo. Log out. Try to log in again. When logging in, in the source, verify the sr-only element for the image header says "Log in to Moodle 4.0".
New login page design introduced with MDL-69371 hardcodes order of strings "sitename" and "login".
Example: if sitename is "Mount Orange School", title is
- in English: "Mount Orange School Log in" (which seems awkward to me, but English is not my first language);
- in French: "Mount Orange School Connexion", which is plain wrong. Notice also the capitalisation of "Connexion", which is wrong too. This should be something like "Connexion à Mount Orange School".
Further notes:
- Usage of "login" string here seems to be in contradiction with https://docs.moodle.org/dev/Coding_style#Capitals and https://docs.moodle.org/dev/Coding_style#String_concatenation
Fix suggestion:
- Add a new lang string for the Login form title, with "sitename" as a parameter, e.g. $string['loginformtitle'] = '{$a} login'; (English), which will translate $string['loginformtitle'] = 'Connexion à {$a}'; in French
- Use this string in file lib/templates/loginform.mustache around line 108.
