Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73719

Redundant theme_reset_all_caches callback

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0
    • 4.0
    • Themes
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • wip_MDL-73719_master
    • Hide
      1. Login as admin.
      2. With the Boost theme, find the setting 'unaddableblocks' and add 'html' to the list.
      3. Turn editing on
      4. Confirm that the 'Text' block does not appear in the list of blocks available to add with 'Add a block'.
      5. Remove 'html' from the 'unaddableblocks' list.
      6. Repeat with the Classic theme and its 'unaddableblocks' setting.
      Show
      Login as admin. With the Boost theme, find the setting 'unaddableblocks' and add 'html' to the list. Turn editing on Confirm that the 'Text' block does not appear in the list of blocks available to add with 'Add a block'. Remove 'html' from the 'unaddableblocks' list. Repeat with the Classic theme and its 'unaddableblocks' setting.

      In MDL-73347, there is a new setting 'unaddableblocks', this in both the Boost and Classic themes is created with the additional callback line:

      $setting->set_updatedcallback('theme_reset_all_caches');

      However, the code makes no changes to the CSS / SCSS and only affects the PHP code (https://github.com/sarjona/moodle/compare/0e188470b1...MDL-73347-master), thus is pointless and will mean a cache refresh causing a page load delay when the setting is changed and yet that is not required.

       

        1. MDL-73719_Boost_Screenshot.PNG
          MDL-73719_Boost_Screenshot.PNG
          34 kB
        2. MDL-73719_Boost _Screenshot.PNG
          MDL-73719_Boost _Screenshot.PNG
          70 kB

            gb2048 Gareth J Barnard
            gb2048 Gareth J Barnard
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 45 minutes
                45m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.